From: Greg KH <gregkh@linuxfoundation.org>
To: Yan Hong <clouds.yan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Alessandro Rubini <rubini@gnudd.com>
Subject: Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32()
Date: Sat, 27 Oct 2012 08:07:15 -0700 [thread overview]
Message-ID: <20121027150715.GD3349@kroah.com> (raw)
In-Reply-To: <1351325129-10097-1-git-send-email-clouds.yan@gmail.com>
On Sat, Oct 27, 2012 at 04:05:25PM +0800, Yan Hong wrote:
> If 'prefix' is not used, pass NULL instead of empty string as the
> last parameter of debugfs_print_regs32().
>
> Cc: Alessandro Rubini <rubini@gnudd.com>
>
> Signed-off-by: Yan Hong <clouds.yan@gmail.com>
> ---
>
> This function is only used (twice) by the author of it, and the
> 'prefix' feature is never used. But it's a well-documented debugfs
> API. It's added one year ago and appeared in many documents. I still
> prefer to let this API stay unchanged and treat the empty string as
> typo.
What "documents" did this appear in? If the parameter isn't being used,
please, just delete it.
greg k-h
next prev parent reply other threads:[~2012-10-27 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 8:05 [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32() Yan Hong
2012-10-27 8:05 ` [PATCH 2/5] debugfs: return directly if failed to allocate memory in debug_fill_super() Yan Hong
2012-10-27 8:05 ` [PATCH 3/5] debugfs: remove redundant initialization in __create_file() Yan Hong
2012-10-27 8:05 ` [PATCH 4/5] debugfs: remove redundant check in __debugfs_remove() Yan Hong
2012-10-27 8:05 ` [PATCH 5/5] debugfs: remove goto in debugfs_remount() Yan Hong
2012-10-27 15:06 ` Greg KH
2012-10-27 16:19 ` Yan Hong
2012-10-27 15:07 ` Greg KH [this message]
2012-10-27 15:45 ` [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32() Alessandro Rubini
2012-10-27 16:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027150715.GD3349@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clouds.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.