From: Alessandro Rubini <rubini@gnudd.com>
To: gregkh@linuxfoundation.org
Cc: clouds.yan@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32()
Date: Sat, 27 Oct 2012 17:45:49 +0200 [thread overview]
Message-ID: <20121027154549.GA7132@mail.gnudd.com> (raw)
In-Reply-To: <20121027150715.GD3349@kroah.com>
>> This function is only used (twice) by the author of it, and the
>> 'prefix' feature is never used.
I introduced it to shrink some internal code that had a lot of
repetition in the debugfs files implementation. In that context I use
the prefix string. Some of the code had later been submitted, but not
yet all of it. Later work by Davide Ciminaghi moved our MFD user to
the regmap interface, according to maintainer's suggestion (which
however means loosing register names from the debugfs dump).
> If the parameter isn't being used, please, just delete it.
It is not currently used by upstream callers, but the function itself
uses it as documented (Documentation/...). I wouldn't remove the
feature and introduce an incompatibility just for this.
/alessandro
next prev parent reply other threads:[~2012-10-27 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 8:05 [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32() Yan Hong
2012-10-27 8:05 ` [PATCH 2/5] debugfs: return directly if failed to allocate memory in debug_fill_super() Yan Hong
2012-10-27 8:05 ` [PATCH 3/5] debugfs: remove redundant initialization in __create_file() Yan Hong
2012-10-27 8:05 ` [PATCH 4/5] debugfs: remove redundant check in __debugfs_remove() Yan Hong
2012-10-27 8:05 ` [PATCH 5/5] debugfs: remove goto in debugfs_remount() Yan Hong
2012-10-27 15:06 ` Greg KH
2012-10-27 16:19 ` Yan Hong
2012-10-27 15:07 ` [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32() Greg KH
2012-10-27 15:45 ` Alessandro Rubini [this message]
2012-10-27 16:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027154549.GA7132@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=clouds.yan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.