From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Dmytro Milinevskyy <milinevskyy@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: ncm: correct endianess conversion
Date: Sun, 28 Oct 2012 18:48:29 +0100 [thread overview]
Message-ID: <20121028174829.GA3761@breakpoint.cc> (raw)
In-Reply-To: <CAOUdcc9PwMg34n_W14ctgW2qqP1P+STan6JBH3uyO+y+jWZ0FQ@mail.gmail.com>
On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote:
> I was trying to keep 2 tabs but checkpatch didn't accept long line
> that's why I killed extra tab.
Then move them to the code section instead to initialize them in the
declaration section.
> >How does it work? Is the test on host side not strict enough?
> The host part(cdc_ncm) does not check this field.
> However I agree that at least on device side this should be corrected.
Good.
> Felipe, do you want me to send another patch or resend previous one
> with this correction?
If it hasn't been applied yet resend it.
> Thanks,
Sebastian
next prev parent reply other threads:[~2012-10-28 17:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 20:59 [PATCH] usb: gadget: ncm: correct endianess conversion Dmytro Milinevskyy
2012-10-24 13:58 ` Sebastian Andrzej Siewior
2012-10-28 17:30 ` Dmytro Milinevskyy
2012-10-28 17:48 ` Sebastian Andrzej Siewior [this message]
2012-10-31 13:33 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2012-11-01 15:16 Dmytro Milinevskyy
2012-11-02 11:46 ` Sergei Shtylyov
2012-11-04 14:30 ` Dmytro Milinevskyy
2012-11-04 14:30 ` Dmytro Milinevskyy
2012-11-06 11:27 ` Felipe Balbi
2012-11-07 13:14 ` Dmytro Milinevskyy
2012-11-08 14:06 ` Felipe Balbi
2012-11-08 19:07 ` Dmytro Milinevskyy
2012-11-08 19:30 ` Felipe Balbi
2012-11-09 9:31 ` Dmytro Milinevskyy
2012-11-09 11:53 ` Felipe Balbi
2012-11-10 18:29 ` Dmytro Milinevskyy
2012-10-30 9:44 Dmytro Milinevskyy
2012-10-31 13:35 ` Felipe Balbi
2012-11-01 15:26 ` Dmytro Milinevskyy
2012-10-04 22:58 Dmytro Milinevskyy
2012-10-08 6:53 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028174829.GA3761@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=milinevskyy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.