Re: [PATCH] usb: gadget: ncm: correct endianess conversion

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

Hi,

On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote:
> Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver.
> Tested on MIPS32 big-endian device.
> 
> Signed-off-by: Dmytro Milinevskyy <milinevskyy@gmail.com>
> ---
>  drivers/usb/gadget/f_ncm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c
> index b651b52..0b9e2ad 100644
> --- a/drivers/usb/gadget/f_ncm.c
> +++ b/drivers/usb/gadget/f_ncm.c
> @@ -102,7 +102,7 @@ static inline unsigned ncm_bitrate(struct usb_gadget *g)
>  				 USB_CDC_NCM_NTB32_SUPPORTED)
>  static struct usb_cdc_ncm_ntb_parameters ntb_parameters = {
> -	.wLength = sizeof ntb_parameters,
> +	.wLength = cpu_to_le16(sizeof(ntb_parameters)),
>  	.bmNtbFormatsSupported = cpu_to_le16(FORMATS_SUPPORTED),
>  	.dwNtbInMaxSize = cpu_to_le32(NTB_DEFAULT_IN_SIZE),
>  	.wNdpInDivisor = cpu_to_le16(4),
> @@ -869,15 +869,15 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port,
>  	struct sk_buff	*skb2;
>  	int		ncb_len = 0;
>  	__le16		*tmp;
> -	int		div = ntb_parameters.wNdpInDivisor;
> -	int		rem = ntb_parameters.wNdpInPayloadRemainder;
> -	int		pad;
> -	int		ndp_align = ntb_parameters.wNdpInAlignment;
> -	int		ndp_pad;
> +	int		div, rem, pad, ndp_align, ndp_pad;

I would not combine them in a single line. Keep them one per line.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]