From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/9] hwmon: (it87) Save temperature registers in 2-dimensional array
Date: Mon, 29 Oct 2012 03:29:38 +0000 [thread overview]
Message-ID: <20121029032938.GA7566@roeck-us.net> (raw)
In-Reply-To: <1351448401-13985-2-git-send-email-linux@roeck-us.net>
On Sun, Oct 28, 2012 at 10:39:54PM +0100, Jean Delvare wrote:
> On Sun, 28 Oct 2012 11:19:53 -0700, Guenter Roeck wrote:
> > Cleaner code, fewer checkpatch errors, and reduced code size
> > (saves more than 500 bytes on x86-64).
>
> I like the idea.
>
Thanks ...
[ ... ]
> > +#define S_IRUGOWU (S_IRUGO | S_IWUSR)
>
> I'm not a big fan of this being defined in a single driver. If you
> think it helps, then it would help several hundred drivers, not just
> this one, so it should be defined in <linux/stat.h>, not locally.
>
It helps me avoid the 80-column limit later on.
I agree, it would be great to have this and similar definitions in
a global include file, I am just not sure if there would be much
of a chance to get it accepted there.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-10-29 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 18:19 [lm-sensors] [PATCH 1/9] hwmon: (it87) Save temperature registers in 2-dimensional array Guenter Roeck
2012-10-28 21:39 ` Jean Delvare
2012-10-29 3:29 ` Guenter Roeck [this message]
2012-10-29 7:34 ` Jean Delvare
2012-10-29 13:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029032938.GA7566@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.