From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Lespiau, Damien" <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite
Date: Mon, 29 Oct 2012 09:32:41 -0700 [thread overview]
Message-ID: <20121029093241.4b168cc0@jbarnes-desktop> (raw)
In-Reply-To: <CAPX-8+-NSmFaZf_WTDG_9bADkD=J+Bs2n5SOenkYW++8jn3BAw@mail.gmail.com>
On Mon, 29 Oct 2012 15:20:15 +0000
"Lespiau, Damien" <damien.lespiau@intel.com> wrote:
> On Sun, Oct 28, 2012 at 10:04 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > We do. However, we don't catch userspace changing the tiling on an
> > existing fb (unless actually pinned)... The extra level of defense is
> > certainly welcome, and provides documentation at all levels on the known
> > capabilities of the hw. (The only downside is that we have more guards to
> > fixup if those ever change, but unlikely ;)
>
> I've sent a new version of this one then, turns out it be useful to
> catch cases where one changes the tiling mode after the creation of
> the fb.
>
Ok sounds good. I'll add my r-b to the latest one.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-10-29 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 17:30 [PATCH] drm/i915: Error out when trying to set a y-tiled as a sprite Damien Lespiau
2012-10-26 17:42 ` Jesse Barnes
2012-10-28 10:04 ` Chris Wilson
2012-10-29 15:20 ` Lespiau, Damien
2012-10-29 16:32 ` Jesse Barnes [this message]
2012-10-29 16:24 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029093241.4b168cc0@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.