All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fanotify: Fix missing break
@ 2012-10-29 15:28 Alan Cox
  0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2012-10-29 15:28 UTC (permalink / raw)
  To: linux-kernel, eparis, akpm

From: Eric Paris <eparis@redhat.com>

Anders Blondell noted in 2010 that Fanotify lost events and provided a test
case. Eric Paris confirmed it was a bug and posted a fix to the list

https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/RrJfTfyW2BE

but never applied it. Repeated attempts over time to actually get him to
apply it have never had a reply from anyone who has raised it

So apply it anyway

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 fs/notify/fanotify/fanotify.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c
index aeb5b5a..0c2f912 100644
--- a/fs/notify/fanotify/fanotify.c
+++ b/fs/notify/fanotify/fanotify.c
@@ -27,6 +27,7 @@ static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new)
 			if ((old->path.mnt == new->path.mnt) &&
 			    (old->path.dentry == new->path.dentry))
 				return true;
+			break;
 		case (FSNOTIFY_EVENT_NONE):
 			return true;
 		default:


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-10-29 15:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-29 15:28 [PATCH] fanotify: Fix missing break Alan Cox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.