All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Jean Pihet <jean.pihet@newoldbits.com>,
	aaro.koskinen@iki.fi, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, khilman@ti.com
Subject: Re: OMAP baseline test results for v3.7-rc1
Date: Tue, 30 Oct 2012 14:54:19 +0200	[thread overview]
Message-ID: <20121030125419.GG29095@arwen.pp.htv.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1210301239310.12697@utopia.booyaka.com>

[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]

Hi,

On Tue, Oct 30, 2012 at 12:50:52PM +0000, Paul Walmsley wrote:
> On Tue, 30 Oct 2012, Felipe Balbi wrote:
> 
> > the wmb() patch should help, but you said it doesn't, right ?
> 
> Correct.  Not sure why you think that would help; the problem is almost 

because of how the driver is behaving...

The only way for omap_i2c_wait_for_bb() to timeout is if the bus is
really still busy; meaning that either transfer hasn't fully completed
(some data still in FIFO), or we didn't send STOP or Repeated START
condition on the bus.

> certainly PM-idle related, given that the problem goes away by reverting 
> Jean's commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc "ARM: OMAP: convert 
> I2C driver to PM QoS for MPU latency constraints".
> 
> The problem is consistent and easy to reproduce here.

I don't doubt that :-) What I think, however, is that PM QoS just made
the problem a bit easier to trigger for whatever reason. Maybe because
pm qos defers constraint updates, or something similar ?

> > without seeing debugging information on the failing case, it'll be very
> > difficult to sort this one out provided noone else seems to be able to
> > reproduce it.
> 
> Aaro sees it also, so it's definitely not a local artifact.

Again I don't doubt it.

> It's not very surprising that the problem doesn't appear with the extra 
> logging enabled, since the extra logging presumably keeps the system out 
> of idle.  
> 
> Anyway, you are welcome to the userspace, bootloader, and X-loader here if 
> you would like to try to reproduce it.  They've been sent to Jean and 
> Kevin and Shubhrajyoti already.  Simply request it and I will send links.

I can have a look, sure, but I don't have the same platform as you have.
I have a beagle XM revB (according to the stickers on the board) which I
could use to try to reproduce, if I manage to, then hooray :-)

In that case, please give me also a link to your uImage so I can make
sure to use the exact same setup.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP baseline test results for v3.7-rc1
Date: Tue, 30 Oct 2012 14:54:19 +0200	[thread overview]
Message-ID: <20121030125419.GG29095@arwen.pp.htv.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1210301239310.12697@utopia.booyaka.com>

Hi,

On Tue, Oct 30, 2012 at 12:50:52PM +0000, Paul Walmsley wrote:
> On Tue, 30 Oct 2012, Felipe Balbi wrote:
> 
> > the wmb() patch should help, but you said it doesn't, right ?
> 
> Correct.  Not sure why you think that would help; the problem is almost 

because of how the driver is behaving...

The only way for omap_i2c_wait_for_bb() to timeout is if the bus is
really still busy; meaning that either transfer hasn't fully completed
(some data still in FIFO), or we didn't send STOP or Repeated START
condition on the bus.

> certainly PM-idle related, given that the problem goes away by reverting 
> Jean's commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc "ARM: OMAP: convert 
> I2C driver to PM QoS for MPU latency constraints".
> 
> The problem is consistent and easy to reproduce here.

I don't doubt that :-) What I think, however, is that PM QoS just made
the problem a bit easier to trigger for whatever reason. Maybe because
pm qos defers constraint updates, or something similar ?

> > without seeing debugging information on the failing case, it'll be very
> > difficult to sort this one out provided noone else seems to be able to
> > reproduce it.
> 
> Aaro sees it also, so it's definitely not a local artifact.

Again I don't doubt it.

> It's not very surprising that the problem doesn't appear with the extra 
> logging enabled, since the extra logging presumably keeps the system out 
> of idle.  
> 
> Anyway, you are welcome to the userspace, bootloader, and X-loader here if 
> you would like to try to reproduce it.  They've been sent to Jean and 
> Kevin and Shubhrajyoti already.  Simply request it and I will send links.

I can have a look, sure, but I don't have the same platform as you have.
I have a beagle XM revB (according to the stickers on the board) which I
could use to try to reproduce, if I manage to, then hooray :-)

In that case, please give me also a link to your uImage so I can make
sure to use the exact same setup.

cheers

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121030/14ae2ba0/attachment.sig>

  reply	other threads:[~2012-10-30 13:00 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  5:20 OMAP baseline test results for v3.7-rc1 Paul Walmsley
2012-10-18  5:20 ` Paul Walmsley
2012-10-18  6:48 ` Paul Walmsley
2012-10-18  6:48   ` Paul Walmsley
2012-10-18  8:37   ` Tero Kristo
2012-10-18  8:37     ` Tero Kristo
2012-10-18  8:48     ` Santosh Shilimkar
2012-10-18  8:48       ` Santosh Shilimkar
2012-10-20 17:30       ` Paul Walmsley
2012-10-20 17:30         ` Paul Walmsley
2012-10-19 16:55 ` Paul Walmsley
2012-10-19 16:55   ` Paul Walmsley
2012-10-19 17:01   ` Felipe Balbi
2012-10-19 17:01     ` Felipe Balbi
2012-10-19 17:56     ` Paul Walmsley
2012-10-19 17:56       ` Paul Walmsley
2012-10-19 18:10       ` Felipe Balbi
2012-10-19 18:10         ` Felipe Balbi
2012-10-19 19:03   ` Aaro Koskinen
2012-10-19 19:03     ` Aaro Koskinen
2012-10-19 19:01     ` Felipe Balbi
2012-10-19 19:01       ` Felipe Balbi
2012-10-19 19:38       ` Aaro Koskinen
2012-10-19 19:38         ` Aaro Koskinen
2012-10-22 17:21         ` Kevin Hilman
2012-10-22 17:21           ` Kevin Hilman
2012-10-22 20:43           ` Kevin Hilman
2012-10-22 20:43             ` Kevin Hilman
2012-10-20  6:14   ` Paul Walmsley
2012-10-20  6:14     ` Paul Walmsley
2012-10-22 16:12     ` Jean Pihet
2012-10-22 16:12       ` Jean Pihet
2012-10-22 17:26       ` Jean Pihet
2012-10-22 17:26         ` Jean Pihet
2012-10-23 19:19         ` Paul Walmsley
2012-10-23 19:19           ` Paul Walmsley
2012-10-23 19:23           ` Jean Pihet
2012-10-23 19:23             ` Jean Pihet
2012-10-25 10:12             ` Felipe Balbi
2012-10-25 10:12               ` Felipe Balbi
2012-10-26 20:15               ` Felipe Balbi
2012-10-26 20:15                 ` Felipe Balbi
2012-10-26 22:03                 ` Paul Walmsley
2012-10-26 22:03                   ` Paul Walmsley
2012-10-29 20:00                   ` Felipe Balbi
2012-10-29 20:00                     ` Felipe Balbi
2012-10-30 12:17                     ` Paul Walmsley
2012-10-30 12:17                       ` Paul Walmsley
2012-10-30 12:32                       ` Felipe Balbi
2012-10-30 12:32                         ` Felipe Balbi
2012-10-30 12:50                         ` Paul Walmsley
2012-10-30 12:50                           ` Paul Walmsley
2012-10-30 12:54                           ` Felipe Balbi [this message]
2012-10-30 12:54                             ` Felipe Balbi
2012-10-30 13:17                             ` Paul Walmsley
2012-10-30 13:17                               ` Paul Walmsley
2012-10-30 14:04                               ` Paul Walmsley
2012-10-30 14:04                                 ` Paul Walmsley
2012-10-31  8:34                                 ` Jean Pihet
2012-10-31  8:34                                   ` Jean Pihet
2012-10-31  9:05                                   ` Rafael J. Wysocki
2012-10-31  9:05                                     ` Rafael J. Wysocki
2012-10-31  8:22                               ` Jean Pihet
2012-10-31  8:22                                 ` Jean Pihet
2012-10-31 10:49                                 ` Kevin Hilman
2012-10-31 10:49                                   ` Kevin Hilman
2012-10-31 21:11                                   ` Jean Pihet
2012-10-31 21:11                                     ` Jean Pihet
2012-11-01  2:44                                     ` Paul Walmsley
2012-11-01  2:44                                       ` Paul Walmsley
2012-11-01  7:51                                       ` Jean Pihet
2012-11-01  7:51                                         ` Jean Pihet
2012-11-03 21:39                                         ` Jean Pihet
2012-11-03 21:39                                           ` Jean Pihet
2012-11-05  3:15                                           ` Paul Walmsley
2012-11-05  3:15                                             ` Paul Walmsley
2012-11-05  9:26                                             ` Jean Pihet
2012-11-05  9:26                                               ` Jean Pihet
2012-11-06  0:01                                               ` Kevin Hilman
2012-11-06  0:01                                                 ` Kevin Hilman
2012-11-06  9:27                                                 ` Jean Pihet
2012-11-06  9:27                                                   ` Jean Pihet
2012-11-06 16:13                                                   ` Paul Walmsley
2012-11-06 16:13                                                     ` Paul Walmsley
2012-11-06 10:06                                                 ` Shubhrajyoti Datta
2012-11-06 10:06                                                   ` Shubhrajyoti Datta
2012-10-30  4:16             ` Paul Walmsley
2012-10-30  4:16               ` Paul Walmsley
2012-10-30  8:54               ` Jean Pihet
2012-10-30  8:54                 ` Jean Pihet
2012-10-30 11:23                 ` Paul Walmsley
2012-10-30 11:23                   ` Paul Walmsley
2012-10-31  8:18                   ` Jean Pihet
2012-10-31  8:18                     ` Jean Pihet
2012-10-23 19:17       ` Kevin Hilman
2012-10-23 19:17         ` Kevin Hilman
2012-10-23 19:18       ` Paul Walmsley
2012-10-23 19:18         ` Paul Walmsley
2012-10-20  6:24   ` Paul Walmsley
2012-10-20  6:24     ` Paul Walmsley
2012-10-22 17:53     ` Kevin Hilman
2012-10-22 17:53       ` Kevin Hilman
2012-10-22 20:44       ` Kevin Hilman
2012-10-22 20:44         ` Kevin Hilman
2012-10-20 14:11 ` Richard Cochran
2012-10-20 14:11   ` Richard Cochran
2012-10-20 16:27   ` Paul Walmsley
2012-10-20 16:27     ` Paul Walmsley
2012-10-20 18:01     ` Richard Cochran
2012-10-20 18:01       ` Richard Cochran
2012-10-20 18:12       ` Paul Walmsley
2012-10-20 18:12         ` Paul Walmsley
2012-10-20 18:37         ` Richard Cochran
2012-10-20 18:37           ` Richard Cochran
2012-10-20 18:58           ` Paul Walmsley
2012-10-20 18:58             ` Paul Walmsley
2012-10-21 13:51             ` Matt Porter
2012-10-21 13:51               ` Matt Porter
2012-10-21 16:26               ` Paul Walmsley
2012-10-21 16:26                 ` Paul Walmsley
2012-10-22 21:56               ` Kevin Hilman
2012-10-22 21:56                 ` Kevin Hilman
2012-10-21  7:35     ` Richard Cochran
2012-10-21  7:35       ` Richard Cochran
2012-10-21  8:23       ` Paul Walmsley
2012-10-21  8:23         ` Paul Walmsley
2012-10-21 11:44         ` Richard Cochran
2012-10-21 11:44           ` Richard Cochran
2012-10-21 16:24           ` Paul Walmsley
2012-10-21 16:24             ` Paul Walmsley
2012-10-21 12:29       ` Mohammed, Afzal
2012-10-21 12:29         ` Mohammed, Afzal
2012-10-21 12:36         ` Richard Cochran
2012-10-21 12:36           ` Richard Cochran
2012-10-20 17:20 ` Paul Walmsley
2012-10-20 17:20   ` Paul Walmsley
2012-10-22 16:13   ` Tero Kristo
2012-10-22 16:13     ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121030125419.GG29095@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=jean.pihet@newoldbits.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.