From: Stephen Hemminger <shemminger@vyatta.com>
To: "Tommy S. Christensen" <tsc@gurgi.dk>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] bridge: bridge port parameters over netlink
Date: Tue, 30 Oct 2012 14:00:09 -0700 [thread overview]
Message-ID: <20121030140009.067f49fa@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <50902115.3090005@gurgi.dk>
On Tue, 30 Oct 2012 19:48:53 +0100
"Tommy S. Christensen" <tsc@gurgi.dk> wrote:
> On 10/30/2012 01:57 AM, Stephen Hemminger wrote:
> >
> > -/*
> > - * Change state of port (ie from forwarding to blocking etc)
> > +static const struct nla_policy ifla_brport_policy[IFLA_BRPORT_MAX + 1] = {
> > + [IFLA_BRPORT_STATE] = { .type = NLA_U8 },
> > + [IFLA_BRPORT_COST] = { .type = NLA_U16 },
> > + [IFLA_BRPORT_PRIORITY] = { .type = NLA_U32 },
> > + [IFLA_BRPORT_MODE] = { .type = NLA_U8 },
> > +};
> > +
>
> Hey Stephen
>
> It seems you've swapped the sizes of COST and PRIORITY in this part.
>
> -Tommy
>
Ok, will fix in next version.
One alternative I considered would be to use previously unused IFLA_PRIORITY and IFLA_COST
which would be more generic. But these fields only really matter to bridge.
next prev parent reply other threads:[~2012-10-30 21:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 0:57 [PATCH net-next 0/8] bridge: new security features Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 1/8] bridge: bridge port parameters over netlink Stephen Hemminger
2012-10-30 18:48 ` Tommy S. Christensen
2012-10-30 21:00 ` Stephen Hemminger [this message]
2012-10-31 14:01 ` John Fastabend
2012-10-31 21:30 ` Stephen Hemminger
2012-11-01 1:33 ` John Fastabend
2012-10-30 0:57 ` [PATCH net-next 2/8] bridge: add template for bridge port flags Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 3/8] bridge: implement BPDU blocking Stephen Hemminger
2012-10-31 2:38 ` Cong Wang
2012-10-31 20:57 ` Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 4/8] bridge: add root port blocking Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 5/8] bridge: add bpdu filter Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 6/8] tun: implement byte queue limits Stephen Hemminger
2012-10-30 1:09 ` Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 7/8] virtio: make some structures const Stephen Hemminger
2012-10-30 1:09 ` Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 8/8] iproute2: handle new bridge PROTINFO format Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030140009.067f49fa@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tsc@gurgi.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.