From: Stephen Hemminger <shemminger@vyatta.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/8] bridge: implement BPDU blocking
Date: Wed, 31 Oct 2012 13:57:48 -0700 [thread overview]
Message-ID: <20121031135748.60a89df3@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <k6q2vm$1ug$1@ger.gmane.org>
On Wed, 31 Oct 2012 02:38:46 +0000 (UTC)
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Tue, 30 Oct 2012 at 00:57 GMT, Stephen Hemminger <shemminger@vyatta.com> wrote:
> > --- a/net/bridge/br_stp_bpdu.c 2012-10-29 17:07:08.005982838 -0700
> > +++ b/net/bridge/br_stp_bpdu.c 2012-10-29 17:31:14.327457434 -0700
> > @@ -170,6 +170,13 @@ void br_stp_rcv(const struct stp_proto *
> > if (!ether_addr_equal(dest, br->group_addr))
> > goto out;
> >
> > + if (p->flags & BR_BPDU_GUARD) {
> > + br_notice(br, "BPDU received on blocked port %u(%s)\n",
> > + (unsigned int) p->port_no, p->dev->name);
>
> net_ratelimit() ?
>
Not necessary since this causes port of bridge to become disabled;
which blocks all further packets (including STP) until manually reset.
next prev parent reply other threads:[~2012-10-31 20:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 0:57 [PATCH net-next 0/8] bridge: new security features Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 1/8] bridge: bridge port parameters over netlink Stephen Hemminger
2012-10-30 18:48 ` Tommy S. Christensen
2012-10-30 21:00 ` Stephen Hemminger
2012-10-31 14:01 ` John Fastabend
2012-10-31 21:30 ` Stephen Hemminger
2012-11-01 1:33 ` John Fastabend
2012-10-30 0:57 ` [PATCH net-next 2/8] bridge: add template for bridge port flags Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 3/8] bridge: implement BPDU blocking Stephen Hemminger
2012-10-31 2:38 ` Cong Wang
2012-10-31 20:57 ` Stephen Hemminger [this message]
2012-10-30 0:57 ` [PATCH net-next 4/8] bridge: add root port blocking Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 5/8] bridge: add bpdu filter Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 6/8] tun: implement byte queue limits Stephen Hemminger
2012-10-30 1:09 ` Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 7/8] virtio: make some structures const Stephen Hemminger
2012-10-30 1:09 ` Stephen Hemminger
2012-10-30 0:57 ` [PATCH net-next 8/8] iproute2: handle new bridge PROTINFO format Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031135748.60a89df3@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.