From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2
Date: Tue, 30 Oct 2012 16:25:27 -0700 [thread overview]
Message-ID: <20121030162527.6081bb74@jbarnes-desktop> (raw)
In-Reply-To: <6c3329$6vu319@orsmga002.jf.intel.com>
On Tue, 30 Oct 2012 21:32:17 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, 30 Oct 2012 18:59:31 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, Oct 26, 2012 at 10:08:38AM -0700, Jesse Barnes wrote:
> > > The BIOS shouldn't be touching this memory across suspend/resume, so
> > > just leave it alone. This saves us ~50ms on resume on my T420.
> > >
> > > v2: change gtt restore default on pre-gen4 (Chris)
> > > move needs_gtt_restore flag into dev_priv
> > >
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > I've just realized: GGTT PTEs are stored in stolen mem, and hence not
> > restored accross S4.
>
> How to ruin the day. So we may as just evict everything upon suspend and
> rebuild as needed?
Yeah Daniel is a party pooper.
So I need to measure this again anyway now that we write combine
things, it may not be worth it anymore (though 2M of writes is still a
fairly large amount). If it's still a long delay, I'll just apply it
to the S3 paths instead of S4.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-10-30 23:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 17:08 [PATCH 1/3] drm/i915: don't block resume on fb console resume Jesse Barnes
2012-10-26 17:08 ` [PATCH 2/3] drm/i915: put ring frequency and turbo setup into a work queue v2 Jesse Barnes
2012-10-30 16:53 ` Rodrigo Vivi
2012-10-30 16:58 ` Jesse Barnes
2012-10-30 17:03 ` Rodrigo Vivi
2012-10-30 17:09 ` Daniel Vetter
2012-10-30 17:17 ` Daniel Vetter
2012-10-31 20:44 ` Jesse Barnes
2012-10-26 17:08 ` [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2 Jesse Barnes
2012-10-28 10:47 ` Chris Wilson
2012-10-30 17:59 ` Daniel Vetter
2012-10-30 21:32 ` Chris Wilson
2012-10-30 21:58 ` Daniel Vetter
2012-10-30 23:25 ` Jesse Barnes [this message]
2012-10-30 16:58 ` [PATCH 1/3] drm/i915: don't block resume on fb console resume Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030162527.6081bb74@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.