From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2
Date: Sun, 28 Oct 2012 10:47:27 +0000 [thread overview]
Message-ID: <b94cdc$74bejo@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1351271318-3148-3-git-send-email-jbarnes@virtuousgeek.org>
On Fri, 26 Oct 2012 10:08:38 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The BIOS shouldn't be touching this memory across suspend/resume, so
> just leave it alone. This saves us ~50ms on resume on my T420.
>
> v2: change gtt restore default on pre-gen4 (Chris)
> move needs_gtt_restore flag into dev_priv
I'm confident that it will work on gen3 now as well, just gen2 remains
doubtful. Hmm, I still have the pnv box that required the GTT rewrite
after resume on my desk... Perhaps a more explicit test for a "sane" BIOS
would be one that provides OpRegion.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-28 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 17:08 [PATCH 1/3] drm/i915: don't block resume on fb console resume Jesse Barnes
2012-10-26 17:08 ` [PATCH 2/3] drm/i915: put ring frequency and turbo setup into a work queue v2 Jesse Barnes
2012-10-30 16:53 ` Rodrigo Vivi
2012-10-30 16:58 ` Jesse Barnes
2012-10-30 17:03 ` Rodrigo Vivi
2012-10-30 17:09 ` Daniel Vetter
2012-10-30 17:17 ` Daniel Vetter
2012-10-31 20:44 ` Jesse Barnes
2012-10-26 17:08 ` [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2 Jesse Barnes
2012-10-28 10:47 ` Chris Wilson [this message]
2012-10-30 17:59 ` Daniel Vetter
2012-10-30 21:32 ` Chris Wilson
2012-10-30 21:58 ` Daniel Vetter
2012-10-30 23:25 ` Jesse Barnes
2012-10-30 16:58 ` [PATCH 1/3] drm/i915: don't block resume on fb console resume Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$74bejo@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.