From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jason Gerecke <killertofu@gmail.com>,
Chris Bagwell <chris@cnpbagwell.com>,
Ping Cheng <pingc@wacom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: wacom - fix a check for WACOM_24HDT
Date: Wed, 31 Oct 2012 05:57:18 +0000 [thread overview]
Message-ID: <20121031055718.GF31983@core.coreip.homeip.net> (raw)
In-Reply-To: <20121029084956.GA7506@elgon.mountain>
On Mon, Oct 29, 2012 at 11:49:56AM +0300, Dan Carpenter wrote:
> The current condition is always true. From the context, it looks like
> we should be checking if ->type = WACOM_24HDT.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you Dan, however I already have a patch from Jason Gerecke
addressing this issue.
>
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index 2c1e12b..858ad44 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
> features->pktlen = WACOM_PKGLEN_TPC2FG;
> }
>
> - if (features->type = MTSCREEN || WACOM_24HDT)
> + if (features->type = MTSCREEN || features->type = WACOM_24HDT)
> features->pktlen = WACOM_PKGLEN_MTOUCH;
>
> if (features->type = BAMBOO_PT) {
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jason Gerecke <killertofu@gmail.com>,
Chris Bagwell <chris@cnpbagwell.com>,
Ping Cheng <pingc@wacom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: wacom - fix a check for WACOM_24HDT
Date: Tue, 30 Oct 2012 22:57:18 -0700 [thread overview]
Message-ID: <20121031055718.GF31983@core.coreip.homeip.net> (raw)
In-Reply-To: <20121029084956.GA7506@elgon.mountain>
On Mon, Oct 29, 2012 at 11:49:56AM +0300, Dan Carpenter wrote:
> The current condition is always true. From the context, it looks like
> we should be checking if ->type == WACOM_24HDT.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you Dan, however I already have a patch from Jason Gerecke
addressing this issue.
>
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index 2c1e12b..858ad44 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
> features->pktlen = WACOM_PKGLEN_TPC2FG;
> }
>
> - if (features->type == MTSCREEN || WACOM_24HDT)
> + if (features->type == MTSCREEN || features->type == WACOM_24HDT)
> features->pktlen = WACOM_PKGLEN_MTOUCH;
>
> if (features->type == BAMBOO_PT) {
--
Dmitry
next prev parent reply other threads:[~2012-10-31 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 8:49 [patch] Input: wacom - fix a check for WACOM_24HDT Dan Carpenter
2012-10-29 8:49 ` Dan Carpenter
2012-10-31 5:57 ` Dmitry Torokhov [this message]
2012-10-31 5:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031055718.GF31983@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pingc@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.