All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pxa: Disable dcache on palmld, palmtc, zipitz2
Date: Wed, 31 Oct 2012 12:55:51 +0100	[thread overview]
Message-ID: <201210311255.51276.marex@denx.de> (raw)
In-Reply-To: <1351640333-12431-1-git-send-email-sjg@chromium.org>

Dear Simon Glass,

> These platforms don't include dcache support. Define CONFIG_SYS_DCACHE_OFF
> so that functions don't try to call non-existent routines like
> flush_dcache_range().
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Is that needed? Why not fix PXA by defining stub cache routines ?

> ---
>  include/configs/palmld.h  |    3 +++
>  include/configs/palmtc.h  |    3 +++
>  include/configs/zipitz2.h |    3 +++
>  3 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/palmld.h b/include/configs/palmld.h
> index c5dd494..3f9802c 100644
> --- a/include/configs/palmld.h
> +++ b/include/configs/palmld.h
> @@ -28,6 +28,9 @@
>  #define	CONFIG_CPU_PXA27X		1	/* Marvell PXA270 CPU */
>  #define	CONFIG_PALMLD		1	/* Palm LifeDrive board */
> 
> +/* we will never enable dcache, because we have to setup MMU first */
> +#define CONFIG_SYS_DCACHE_OFF
> +
>  /*
>   * Environment settings
>   */
> diff --git a/include/configs/palmtc.h b/include/configs/palmtc.h
> index 9c948c5..64771e7 100644
> --- a/include/configs/palmtc.h
> +++ b/include/configs/palmtc.h
> @@ -30,6 +30,9 @@
>  #define	CONFIG_CPU_PXA25X			1	/* Intel PXA255 
CPU */
>  #define	CONFIG_PALMTC			1	/* Palm Tungsten|C board 
*/
> 
> +/* we will never enable dcache, because we have to setup MMU first */
> +#define CONFIG_SYS_DCACHE_OFF
> +
>  /*
>   * Environment settings
>   */
> diff --git a/include/configs/zipitz2.h b/include/configs/zipitz2.h
> index bf6394a..b92f70b 100644
> --- a/include/configs/zipitz2.h
> +++ b/include/configs/zipitz2.h
> @@ -41,6 +41,9 @@
>  #define CONFIG_ENV_ADDR			0x40000
>  #define CONFIG_ENV_SIZE			0x20000
> 
> +/* we will never enable dcache, because we have to setup MMU first */
> +#define CONFIG_SYS_DCACHE_OFF
> +
>  #define	CONFIG_SYS_MALLOC_LEN		(128*1024)
>  #define	CONFIG_ARCH_CPU_INIT

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-31 11:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30 23:38 [U-Boot] [PATCH] pxa: Disable dcache on palmld, palmtc, zipitz2 Simon Glass
2012-10-31 11:55 ` Marek Vasut [this message]
2012-10-31 14:44   ` Tom Rini
2012-10-31 16:41     ` Marek Vasut
2012-10-31 16:52       ` Tom Warren
2012-11-05 20:47         ` Simon Glass
2012-11-05 22:59           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210311255.51276.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.