From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pxa: Disable dcache on palmld, palmtc, zipitz2
Date: Wed, 31 Oct 2012 17:41:08 +0100 [thread overview]
Message-ID: <201210311741.08889.marex@denx.de> (raw)
In-Reply-To: <50913966.2010808@ti.com>
Dear Tom Rini,
> On 10/31/12 04:55, Marek Vasut wrote:
> > Dear Simon Glass,
> >
> >> These platforms don't include dcache support. Define
> >> CONFIG_SYS_DCACHE_OFF so that functions don't try to call
> >> non-existent routines like flush_dcache_range().
> >>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > Is that needed? Why not fix PXA by defining stub cache routines ?
>
> Adding stubs sounds more like a work-around than disabling support
> that we won't have to me.
Yes, but then, the stubs will be optimized out.
I see using CONFIG_SYS_DCACHE_OFF being abused here. Every platform should
implement at least cache operations stubs, then it'd be valid to use
CONFIG_SYS_DCACHE_OFF to indicate the cache shall always be off. But the code
would at least compile and work with CONFIG_SYS_DCACHE_OFF enabled or disabled.
We might eventually even be able to weed out this CONFIG_SYS_DCACHE_OFF option.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-31 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 23:38 [U-Boot] [PATCH] pxa: Disable dcache on palmld, palmtc, zipitz2 Simon Glass
2012-10-31 11:55 ` Marek Vasut
2012-10-31 14:44 ` Tom Rini
2012-10-31 16:41 ` Marek Vasut [this message]
2012-10-31 16:52 ` Tom Warren
2012-11-05 20:47 ` Simon Glass
2012-11-05 22:59 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210311741.08889.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.