From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera
Date: Wed, 31 Oct 2012 20:02:49 +0100 [thread overview]
Message-ID: <20121031190249.GO1641@pengutronix.de> (raw)
In-Reply-To: <20121031165303.32921a5c@infradead.org>
On Wed, Oct 31, 2012 at 04:53:03PM -0200, Mauro Carvalho Chehab wrote:
> Em Wed, 31 Oct 2012 14:53:47 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
>
> > On Wed, 31 Oct 2012, Fabio Estevam wrote:
> >
> > > Hi Sascha,
> > >
> > > On Wed, Oct 31, 2012 at 11:16 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > >
> > > > Quoting yourself:
> > > >
> > > >> Forgot to comment: as patch 2 relies on this change, the better, IMHO, is
> > > >> to send both via the same tree. If you decide to do so, please get arm
> > > >> maintainer's ack, instead, and we can merge both via my tree.
> > > >
> > > > That's why Fabio resent these patches with my Ack. You are free to take
> > > > these.
> > >
> > > I have just realized that this patch (1/2) will not apply against
> > > media tree because it does not have commit 27b76486a3 (media:
> > > mx2_camera: remove cpu_is_xxx by using platform_device_id), which
> > > changes from mx2_camera.0 to imx27-camera.0.
> >
> > This is exactly the reason why I wasn't able to merge it. The problem was,
> > that this "media: mx2_camera: remove cpu_is_xxx by using
> > platform_device_id" patch non-trivially touched both arch/arm/ and
> > drivers/media/ directories. And being patch 27/34 I didn't feel like
> > asking the author to redo it again:-) This confirms, that it's better to
> > avoid such overlapping patches whenever possible.
> >
> > > So it seems to be better to merge this via arm tree to avoid such conflict.
>
> I agree with Fabio and Guennadi. There are so many changes happening at arm
> that merging those two patches there will likely be easier for everybody.
Ok, then I'll take them. I wasn't aware in arm-soc are sitting patches
for this driver already.
>
> Otherwise, I'll need to pull from some arm tree that never rebase, with
> the needed patches, and coordinate with you during the merge window,
> to be sure that patches will arrive there at the right order, from the
> right tree.
Hopefully these kind of cross dependencies become fewer over time. SoC
code is getting smaller and gets better abstracted from the drivers, so
chances are good.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Fabio Estevam <festevam@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
kernel@pengutronix.de, gcembed@gmail.com,
javier Martin <javier.martin@vista-silicon.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera
Date: Wed, 31 Oct 2012 20:02:49 +0100 [thread overview]
Message-ID: <20121031190249.GO1641@pengutronix.de> (raw)
In-Reply-To: <20121031165303.32921a5c@infradead.org>
On Wed, Oct 31, 2012 at 04:53:03PM -0200, Mauro Carvalho Chehab wrote:
> Em Wed, 31 Oct 2012 14:53:47 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
>
> > On Wed, 31 Oct 2012, Fabio Estevam wrote:
> >
> > > Hi Sascha,
> > >
> > > On Wed, Oct 31, 2012 at 11:16 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > >
> > > > Quoting yourself:
> > > >
> > > >> Forgot to comment: as patch 2 relies on this change, the better, IMHO, is
> > > >> to send both via the same tree. If you decide to do so, please get arm
> > > >> maintainer's ack, instead, and we can merge both via my tree.
> > > >
> > > > That's why Fabio resent these patches with my Ack. You are free to take
> > > > these.
> > >
> > > I have just realized that this patch (1/2) will not apply against
> > > media tree because it does not have commit 27b76486a3 (media:
> > > mx2_camera: remove cpu_is_xxx by using platform_device_id), which
> > > changes from mx2_camera.0 to imx27-camera.0.
> >
> > This is exactly the reason why I wasn't able to merge it. The problem was,
> > that this "media: mx2_camera: remove cpu_is_xxx by using
> > platform_device_id" patch non-trivially touched both arch/arm/ and
> > drivers/media/ directories. And being patch 27/34 I didn't feel like
> > asking the author to redo it again:-) This confirms, that it's better to
> > avoid such overlapping patches whenever possible.
> >
> > > So it seems to be better to merge this via arm tree to avoid such conflict.
>
> I agree with Fabio and Guennadi. There are so many changes happening at arm
> that merging those two patches there will likely be easier for everybody.
Ok, then I'll take them. I wasn't aware in arm-soc are sitting patches
for this driver already.
>
> Otherwise, I'll need to pull from some arm tree that never rebase, with
> the needed patches, and coordinate with you during the merge window,
> to be sure that patches will arrive there at the right order, from the
> right tree.
Hopefully these kind of cross dependencies become fewer over time. SoC
code is getting smaller and gets better abstracted from the drivers, so
chances are good.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-10-31 19:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 12:03 [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera Fabio Estevam
2012-10-30 12:03 ` Fabio Estevam
2012-10-30 12:03 ` [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion Fabio Estevam
2012-10-30 12:03 ` Fabio Estevam
2012-10-31 11:57 ` Mauro Carvalho Chehab
2012-10-31 11:57 ` Mauro Carvalho Chehab
2012-11-14 18:22 ` Fabio Estevam
2012-11-14 18:22 ` Fabio Estevam
2012-11-14 19:58 ` Sascha Hauer
2012-11-14 19:58 ` Sascha Hauer
2012-10-31 11:56 ` [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera Mauro Carvalho Chehab
2012-10-31 11:56 ` Mauro Carvalho Chehab
2012-10-31 13:16 ` Sascha Hauer
2012-10-31 13:16 ` Sascha Hauer
2012-10-31 13:24 ` Fabio Estevam
2012-10-31 13:24 ` Fabio Estevam
2012-10-31 13:53 ` Guennadi Liakhovetski
2012-10-31 13:53 ` Guennadi Liakhovetski
2012-10-31 18:53 ` Mauro Carvalho Chehab
2012-10-31 18:53 ` Mauro Carvalho Chehab
2012-10-31 19:02 ` Sascha Hauer [this message]
2012-10-31 19:02 ` Sascha Hauer
2012-10-31 19:50 ` Mauro Carvalho Chehab
2012-10-31 19:50 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031190249.GO1641@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.