From: "George Spelvin" <linux@horizon.com>
To: darrick.wong@oracle.com, tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, linux@horizon.com, tm@tao.ma
Subject: Re: ext4: fix metadata checksum calculation for the superblock
Date: 1 Nov 2012 02:12:12 -0400 [thread overview]
Message-ID: <20121101061212.16497.qmail@science.horizon.com> (raw)
In-Reply-To: <20121101015015.GA28919@thunk.org>
> This one was cc'ed to stable@vger.kernel.org. But when you said "I
> notice, that neither of thse have made it into 2.6.5", I assume you
> meant 3.5?
Whoops, typo! I meant 3.6.5, the very latest just-out-today stable
kernel.
Quite a few 3.6.x kernels have come out since that patch was Cc'ed,
and it keeps not being included. So I wondered.
> So that means it should eventually make it to the 3.4.x and 3.6.x
> kernels.
That's what I thought, but I didn't want to pester Greg until I was sure
of your intentions.
> At this point I'll just include it in the patches to be sent to Linus
> at the next merge window, mainly because I don't have the time to run
> a separate regression test run just for this patch, and it's only a
> cosmetic issue, right?
Well, it causes the file system to be marked dirty and unnecessarily
checked on reboot, which I contend is a bug, but it's not a data-loss
bug.
I do worry that it could cause file lookup to fail when it shouldn't,
which *is* effectively a data-loss bug, even if the data reappears
on reboot. But I'd have to understand the problem and fix better to
know if that actually happens; I haven't observed it.
next prev parent reply other threads:[~2012-11-01 6:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 5:04 metadata_csum + unclean shutdown = failure to boot George Spelvin
2012-10-07 13:39 ` Tao Ma
2012-10-07 15:09 ` George Spelvin
2012-10-07 18:10 ` Theodore Ts'o
2012-10-07 20:18 ` George Spelvin
2012-10-07 22:54 ` Theodore Ts'o
2012-10-08 1:05 ` George Spelvin
2012-10-08 1:25 ` George Spelvin
2012-10-08 2:41 ` Theodore Ts'o
2012-10-08 3:17 ` George Spelvin
2012-10-08 4:03 ` Tao Ma
2012-10-08 11:35 ` George Spelvin
2012-11-01 1:05 ` ext4: fix metadata checksum calculation for the superblock George Spelvin
2012-11-01 1:13 ` Darrick J. Wong
2012-11-01 1:50 ` Theodore Ts'o
2012-11-01 3:22 ` Darrick J. Wong
2012-11-01 6:12 ` George Spelvin [this message]
2012-11-01 6:49 ` Darrick J. Wong
2012-11-01 7:07 ` George Spelvin
2012-11-01 7:18 ` Darrick J. Wong
2012-11-01 7:28 ` George Spelvin
2012-11-02 0:05 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101061212.16497.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.