All of lore.kernel.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: darrick.wong@oracle.com, linux@horizon.com
Cc: linux-ext4@vger.kernel.org, tm@tao.ma, tytso@mit.edu
Subject: Re: ext4: fix metadata checksum calculation for the superblock
Date: 1 Nov 2012 03:28:47 -0400	[thread overview]
Message-ID: <20121101072847.25732.qmail@science.horizon.com> (raw)
In-Reply-To: <20121101071818.GG19576@blackbox.djwong.org>

> Oh, so ... it's just nfsd that causes the linear fallback?  Regular (i.e.
> non-nfs) users can see everything in the dir, no error messages?

Yup.  After it survived one e2fsck -D, I poked at the directory a bit
to see if I could cause the error.  No success from local access.

It's also probably an NFSv2 client.  I wonder if it's doing something
odd with directory seeks that's causing problems; perhaps htree and the
32-bit seek cookie limit are not friends?

>> I haven't observed it, no.  But the nature of the symptoms suggests it
>> might be happening.

> Hum.  When linear scan happens on a hashed dir, it's scanning the same
> blocks that the hash scan sees.   The htree block looks like a regular
> directory block with one huge "unused" dirent that wraps all the htree
> data.  So, the linear scan should find the exact same files as a htree
> scan would.  If it doesn't, something's wrong.  But you say it isn't,
> so I imagine it's fine.

Maybe I was wrong.  I was worried that it was aborting the directory
scan due to the error and thus files would disappear.  If that doesn't
happen, no worries.

  reply	other threads:[~2012-11-01  7:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07  5:04 metadata_csum + unclean shutdown = failure to boot George Spelvin
2012-10-07 13:39 ` Tao Ma
2012-10-07 15:09   ` George Spelvin
2012-10-07 18:10     ` Theodore Ts'o
2012-10-07 20:18       ` George Spelvin
2012-10-07 22:54         ` Theodore Ts'o
2012-10-08  1:05           ` George Spelvin
2012-10-08  1:25           ` George Spelvin
2012-10-08  2:41             ` Theodore Ts'o
2012-10-08  3:17               ` George Spelvin
2012-10-08  4:03                 ` Tao Ma
2012-10-08 11:35                   ` George Spelvin
2012-11-01  1:05               ` ext4: fix metadata checksum calculation for the superblock George Spelvin
2012-11-01  1:13                 ` Darrick J. Wong
2012-11-01  1:50                   ` Theodore Ts'o
2012-11-01  3:22                     ` Darrick J. Wong
2012-11-01  6:12                     ` George Spelvin
2012-11-01  6:49                       ` Darrick J. Wong
2012-11-01  7:07                         ` George Spelvin
2012-11-01  7:18                           ` Darrick J. Wong
2012-11-01  7:28                             ` George Spelvin [this message]
2012-11-02  0:05                               ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121101072847.25732.qmail@science.horizon.com \
    --to=linux@horizon.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tm@tao.ma \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.