All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@fusionio.com>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option
Date: Thu, 1 Nov 2012 10:43:23 -0400	[thread overview]
Message-ID: <20121101144323.GB8307@shiny> (raw)
In-Reply-To: <1351333721-3220-2-git-send-email-bo.li.liu@oracle.com>

On Sat, Oct 27, 2012 at 04:28:41AM -0600, Liu Bo wrote:
> This feature works on our crucial write endio path, so if we've got
> lots of fragments to process, it will be kind of a disaster to the
> performance, so I make such a change.
> 
> One can benifit from it while mounting with '-o snap_aware_defrag'.

I think we should always prefer to maintain snapshot cloning as much as
possible, and have a specific option to defrag that makes it break the
clone in favor of removing fragmentation.

So, please keep the snapshot aware defrag the default ;)

Thanks for taking these patches up again!

-chris

  parent reply	other threads:[~2012-11-01 14:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 10:28 [PATCH 1/2 v4] Btrfs: snapshot-aware defrag Liu Bo
2012-10-27 10:28 ` [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option Liu Bo
2012-10-30 23:31   ` David Sterba
2012-10-31  0:34     ` Liu Bo
2012-10-31  0:44       ` David Sterba
2012-10-31 13:31         ` Liu Bo
2012-11-01 14:43   ` Chris Mason [this message]
2012-11-01 15:49     ` Liu Bo
2012-10-29 20:06 ` [PATCH 1/2 v4] Btrfs: snapshot-aware defrag Mitch Harder
2012-10-30  1:20   ` Liu Bo
2012-10-30 20:59     ` Mitch Harder
2012-10-31 12:13 ` Itaru Kitayama
2012-10-31 12:55   ` Liu Bo
2012-11-01 11:08     ` Itaru Kitayama
2012-11-01 11:21       ` Liu Bo
2012-11-01 14:05         ` Itaru Kitayama
2012-11-01 16:01           ` Liu Bo
     [not found]             ` <CANW9uyt9qE9384WnQq5ggZ2hb-DbahZe8KY5-WXRFSKTiedekg@mail.gmail.com>
2012-11-26 10:30               ` Liu Bo
2012-12-12 19:37         ` Mitch Harder
2012-12-13  1:28           ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121101144323.GB8307@shiny \
    --to=chris.mason@fusionio.com \
    --cc=bo.li.liu@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.