Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

[Liu Bo <bo.li.liu@oracle.com>]

On 11/01/2012 10:43 PM, Chris Mason wrote:
> On Sat, Oct 27, 2012 at 04:28:41AM -0600, Liu Bo wrote:
>> This feature works on our crucial write endio path, so if we've got
>> lots of fragments to process, it will be kind of a disaster to the
>> performance, so I make such a change.
>>
>> One can benifit from it while mounting with '-o snap_aware_defrag'.
> 
> I think we should always prefer to maintain snapshot cloning as much as
> possible, and have a specific option to defrag that makes it break the
> clone in favor of removing fragmentation.
> 

Oh yeah, so I was considering the existing btrfs partitions who have already
broke the cloning relationship.

> So, please keep the snapshot aware defrag the default ;)
> 

All right, that'd be nice, just drop this patch.

thanks,
liubo

> Thanks for taking these patches up again!
> 
> -chris
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>