From: Minchan Kim <minchan@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Android Kernel Team <kernel-team@android.com>,
Robert Love <rlove@google.com>, Mel Gorman <mel@csn.ul.ie>,
Hugh Dickins <hughd@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>,
Dave Chinner <david@fromorbit.com>, Neil Brown <neilb@suse.de>,
Mike Hommey <mh@glandium.org>, Taras Glek <tglek@mozilla.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [RFC] Support volatile range for anon vma
Date: Fri, 2 Nov 2012 11:32:20 +0900 [thread overview]
Message-ID: <20121102023220.GA3326@bbox> (raw)
In-Reply-To: <0000013abda6fc7d-6cfbef1e-bc7d-4f4f-bb38-221729e8c9f9-000000@email.amazonses.com>
Hi Christoph,
On Thu, Nov 01, 2012 at 08:26:09PM +0000, Christoph Lameter wrote:
> On Fri, 26 Oct 2012, Minchan Kim wrote:
>
> > I guess it would improve system performance very well.
> > But as I wrote down in description, downside of the patch is that we have to
> > age anon lru although we don't have swap. But gain via the patch is bigger than
> > loss via aging of anon lru when memory pressure happens. I don't see other downside
> > other than it. What do you think about it?
> > (I didn't implement anon lru aging in case of no-swap but it's trivial
> > once we decide)
>
>
> I am a bit confused like some of the others as to why this patch is
> necessary since we already have DONT_NEED.
Totally, my fault. I should have written clearly.
DONT_NEED have to zap all pte entries/tlb flush when system call
happens so DONT_NEED isn't cheap.
Even, later if user accesses address again, page fault happens.
This patch is to remove above two overheads.
while I discussed with KOSAKI, I found there was trial of simillar
goal by Rik. https://lkml.org/lkml/2007/4/17/53
But as I look over the code, it seems to have a cost about setting PG_lazyfree
on all pages of range which isn't in my implementation.
Anyway, I would like to know where Rik's patch wasn't merged at that time.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Android Kernel Team <kernel-team@android.com>,
Robert Love <rlove@google.com>, Mel Gorman <mel@csn.ul.ie>,
Hugh Dickins <hughd@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Rik van Riel <riel@redhat.com>,
Dave Chinner <david@fromorbit.com>, Neil Brown <neilb@suse.de>,
Mike Hommey <mh@glandium.org>, Taras Glek <tglek@mozilla.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [RFC] Support volatile range for anon vma
Date: Fri, 2 Nov 2012 11:32:20 +0900 [thread overview]
Message-ID: <20121102023220.GA3326@bbox> (raw)
In-Reply-To: <0000013abda6fc7d-6cfbef1e-bc7d-4f4f-bb38-221729e8c9f9-000000@email.amazonses.com>
Hi Christoph,
On Thu, Nov 01, 2012 at 08:26:09PM +0000, Christoph Lameter wrote:
> On Fri, 26 Oct 2012, Minchan Kim wrote:
>
> > I guess it would improve system performance very well.
> > But as I wrote down in description, downside of the patch is that we have to
> > age anon lru although we don't have swap. But gain via the patch is bigger than
> > loss via aging of anon lru when memory pressure happens. I don't see other downside
> > other than it. What do you think about it?
> > (I didn't implement anon lru aging in case of no-swap but it's trivial
> > once we decide)
>
>
> I am a bit confused like some of the others as to why this patch is
> necessary since we already have DONT_NEED.
Totally, my fault. I should have written clearly.
DONT_NEED have to zap all pte entries/tlb flush when system call
happens so DONT_NEED isn't cheap.
Even, later if user accesses address again, page fault happens.
This patch is to remove above two overheads.
while I discussed with KOSAKI, I found there was trial of simillar
goal by Rik. https://lkml.org/lkml/2007/4/17/53
But as I look over the code, it seems to have a cost about setting PG_lazyfree
on all pages of range which isn't in my implementation.
Anyway, I would like to know where Rik's patch wasn't merged at that time.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-11-02 2:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 2:57 [RFC] Support volatile range for anon vma Minchan Kim
2012-10-25 2:57 ` Minchan Kim
2012-10-25 15:19 ` Christoph Lameter
2012-10-25 15:19 ` Christoph Lameter
2012-10-26 0:58 ` Minchan Kim
2012-10-26 0:58 ` Minchan Kim
2012-11-01 20:26 ` Christoph Lameter
2012-11-01 20:26 ` Christoph Lameter
2012-11-02 2:32 ` Minchan Kim [this message]
2012-11-02 2:32 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102023220.GA3326@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dave@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=hughd@google.com \
--cc=john.stultz@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel-team@android.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mh@glandium.org \
--cc=neilb@suse.de \
--cc=riel@redhat.com \
--cc=rlove@google.com \
--cc=tglek@mozilla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.