From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de,
Javier Martin <javier.martin@vista-silicon.com>,
w.sang@pengutronix.de, lrg@ti.com
Subject: Re: [PATCH v2 2/2] ASoC: tlv320aic32x4: Add rstn gpio to platform data.
Date: Fri, 2 Nov 2012 14:40:27 +0000 [thread overview]
Message-ID: <20121102144027.GB4413@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5092953B.9080109@topic.nl>
[-- Attachment #1.1: Type: text/plain, Size: 827 bytes --]
On Thu, Nov 01, 2012 at 04:28:59PM +0100, Mike Looijmans wrote:
> >This breaks down if any of the drivers actually uses the reset pin to
> >reset the chip - if the reset might not actually happen but the driver
> >wants it to happen then things are going to go wrong.
> Good point. But in that case, the gpio cannot be "optional", the
> board file MUST supply it.
Well, what normally happens is that the driver has some alternative
ways of doing what it wants but if there's a reset signal present it
wants to actually use it and be able to rely on it doing the job.
> Do I understand correctly that I'm totally alone in this and that
> there is no point in uploading the code?
If you want to do something like this you should explictly model reset
lines like this rather than shoehorning them into a different subsystem.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-11-02 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 10:53 [PATCH v2 1/2] ASoC: tlv320aic32x4: Fix problem with first capture Javier Martin
2012-10-31 10:53 ` [PATCH v2 2/2] ASoC: tlv320aic32x4: Add rstn gpio to platform data Javier Martin
2012-10-31 14:40 ` Mike Looijmans
2012-11-01 14:35 ` Mark Brown
2012-11-01 15:28 ` Mike Looijmans
2012-11-02 14:40 ` Mark Brown [this message]
2012-11-05 8:14 ` javier Martin
2012-11-05 8:15 ` Mark Brown
2012-11-01 14:36 ` [PATCH v2 1/2] ASoC: tlv320aic32x4: Fix problem with first capture Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102144027.GB4413@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=javier.martin@vista-silicon.com \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
--cc=mike.looijmans@topic.nl \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.