Re: [PATCH v2 2/2] ASoC: tlv320aic32x4: Add rstn gpio to platform data.

[Mike Looijmans <mike.looijmans@topic.nl>]

On 10/31/2012 11:53 AM, Javier Martin wrote:
> Add the possibility to specify a gpio through platform data
> so that a HW reset can be issued to the codec.
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> ---
> Changes since v1:
>   - Use a subject line according to the ASoC subsystem.
>   - Use 'devm_gpio_request_one()'
>   - Provide correct default value to the GPIO.
>

Now that I see your patch - I modelled the RESET pins (and the power 
supply pins) as power supply inputs, and request them to be active when 
the bias goes into standby or higher. Keeping the chip in RESET is a 
very nice power saving feature. I just cache all the register settings 
up until that point (which required a bit of coding because of the 
"paging" of the I2C address space).

The reason that I also made RESET a "power" rather than a GPIO is that I 
have seven codecs, using three GPIO lines (in 3/3/1 configuration) to 
reset the chips. Having the RESET pin modelled as a powersupply allowed 
the codec instance to blindly turn it on, letting the powersupply keep 
track of the number of clients.

It was the best I could think off at the time, and it made me wonder why 
those reset lines aren't modelled this way more often.

If anyone's interested, I can upload the modified source. A patch is 
difficult, because I did horrible things to the code for our specific needs.

What's your view on this?


Mike.


Met vriendelijke groet / kind regards,

Mike Looijmans

TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) – (0)499 - 33.69.79
Telefax: (+31) - (0)499 - 33.69.70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl

Dit e-mail bericht en de eventueel daarbij behorende bijlagen zijn uitsluitend bestemd voor de geadresseerde, zoals die blijkt uit het e-mail bericht en/of de bijlagen. Er kunnen gegevens met betrekking tot een derde instaan. Indien u als niet-geadresseerde dit bericht en de bijlagen ontvangt, terwijl u niet bevoegd of gemachtigd bent om dit bericht namens de geadresseerde te ontvangen, wordt u verzocht de afzender hierover direct te informeren en het e-mail bericht met de bijlagen te vernietigen. Ieder gebruik van de inhoud van het e-mail bericht, waaronder de daarbij behorende bijlagen, door een ander dan de geadresseerde is onrechtmatig jegens ons dan wel de eventueel in het e-mail bericht of de bijlagen voorkomende andere personen. TOPIC Embedded Systems is niet aansprakelijk voor enigerlei schade voortvloeiend uit het gebruik en/of acceptatie van dit e-mail bericht of de daarbij behorende bijlagen.

The contents of this message, as well as any enclosures, are addressed personally to, and thus solely intended for the addressee. They may contain information regarding a third party. A recipient who is neither the addressee, nor empowered to receive this message on behalf of the addressee, is kindly requested to immediately inform the sender of receipt, and to destroy the message and the enclosures. Any use of the contents of this message and/or the enclosures by any other person than the addressee or person who is empowered to receive this message, is illegal towards the sender and/or the aforementioned third party. TOPIC Embedded Systems is not  liable for any damage as a result of the use and/or acceptance of this message and as well as any enclosures.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel