From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: "ludovic.desroches"
<ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: "Voss, Nikolaus" <N.Voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] i2c: at91: add a sanity check on i2c message length
Date: Sat, 3 Nov 2012 15:16:24 +0100 [thread overview]
Message-ID: <20121103141624.GA24952@pengutronix.de> (raw)
In-Reply-To: <5093EE2B.8080005-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
> >>Yes SMBUS quick command is supported but is not managed in the
> >>driver, we have to tell explicitly the IP that we want to send this
> >>command.
> >
> >Ok, so unless you want to implement the support, please update this
> >patch with a comment that SMBUS_QUICK is a TODO and remove the
> >SMBUS_QUICK capability.
> >
>
> Implementation should not be a huge task, only one bit to set in a
> register but I have no device to test it.
'i2cdetect' from i2c-tools uses SMBUS_QUICK as one method to detect
chips. Most slaves (both I2C and SMBus) react to that, so that would do
in my book.
> Did you test the driver with SMBus compatible devices? Can I keep
> other SMBus capabilities from SMBUS_EMUL?
The rest should be fine.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: at91: add a sanity check on i2c message length
Date: Sat, 3 Nov 2012 15:16:24 +0100 [thread overview]
Message-ID: <20121103141624.GA24952@pengutronix.de> (raw)
In-Reply-To: <5093EE2B.8080005@atmel.com>
> >>Yes SMBUS quick command is supported but is not managed in the
> >>driver, we have to tell explicitly the IP that we want to send this
> >>command.
> >
> >Ok, so unless you want to implement the support, please update this
> >patch with a comment that SMBUS_QUICK is a TODO and remove the
> >SMBUS_QUICK capability.
> >
>
> Implementation should not be a huge task, only one bit to set in a
> register but I have no device to test it.
'i2cdetect' from i2c-tools uses SMBUS_QUICK as one method to detect
chips. Most slaves (both I2C and SMBus) react to that, so that would do
in my book.
> Did you test the driver with SMBus compatible devices? Can I keep
> other SMBus capabilities from SMBUS_EMUL?
The rest should be fine.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121103/b3b8259b/attachment.sig>
next prev parent reply other threads:[~2012-11-03 14:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:25 [PATCH] i2c: at91: add a sanity check on i2c message length ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
2012-10-10 14:25 ` ludovic.desroches at atmel.com
2012-10-24 14:34 ` ludovic.desroches
2012-10-24 14:34 ` ludovic.desroches
[not found] ` <1349879158-27268-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-01 22:29 ` Wolfram Sang
2012-11-01 22:29 ` Wolfram Sang
2012-11-02 11:04 ` ludovic.desroches
2012-11-02 11:04 ` ludovic.desroches
[not found] ` <5093A8CD.60006-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-02 11:14 ` Wolfram Sang
2012-11-02 11:14 ` Wolfram Sang
2012-11-02 16:00 ` ludovic.desroches
2012-11-02 16:00 ` ludovic.desroches
[not found] ` <5093EE2B.8080005-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-03 14:16 ` Wolfram Sang [this message]
2012-11-03 14:16 ` Wolfram Sang
2012-11-05 6:08 ` Voss, Nikolaus
2012-11-05 6:08 ` Voss, Nikolaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121103141624.GA24952@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=N.Voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.