From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] xen/arm: use the __HVC macro
Date: Mon, 5 Nov 2012 10:58:17 +0000 [thread overview]
Message-ID: <20121105105817.GC2005@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1210241624400.2689@kaball.uk.xensource.com>
On Wed, Oct 24, 2012 at 04:26:08PM +0100, Stefano Stabellini wrote:
> Use the new __HVC macro in hypercall.S.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
This is correct usage of the __HVC() macro, so
Acked-by: Dave Martin <dave.martin@linaro.org>
> ---
> arch/arm/xen/hypercall.S | 14 +++++---------
> 1 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/xen/hypercall.S b/arch/arm/xen/hypercall.S
> index 074f5ed..71f7239 100644
> --- a/arch/arm/xen/hypercall.S
> +++ b/arch/arm/xen/hypercall.S
> @@ -48,20 +48,16 @@
>
> #include <linux/linkage.h>
> #include <asm/assembler.h>
> +#include <asm/opcodes-virt.h>
> #include <xen/interface/xen.h>
>
>
> -/* HVC 0xEA1 */
> -#ifdef CONFIG_THUMB2_KERNEL
> -#define xen_hvc .word 0xf7e08ea1
> -#else
> -#define xen_hvc .word 0xe140ea71
> -#endif
> +#define XEN_IMM 0xEA1
>
> #define HYPERCALL_SIMPLE(hypercall) \
> ENTRY(HYPERVISOR_##hypercall) \
> mov r12, #__HYPERVISOR_##hypercall; \
> - xen_hvc; \
> + __HVC(XEN_IMM); \
> mov pc, lr; \
> ENDPROC(HYPERVISOR_##hypercall)
>
> @@ -76,7 +72,7 @@ ENTRY(HYPERVISOR_##hypercall) \
> stmdb sp!, {r4} \
> ldr r4, [sp, #4] \
> mov r12, #__HYPERVISOR_##hypercall; \
> - xen_hvc \
> + __HVC(XEN_IMM); \
> ldm sp!, {r4} \
> mov pc, lr \
> ENDPROC(HYPERVISOR_##hypercall)
> @@ -100,7 +96,7 @@ ENTRY(privcmd_call)
> mov r2, r3
> ldr r3, [sp, #8]
> ldr r4, [sp, #4]
> - xen_hvc
> + __HVC(XEN_IMM)
> ldm sp!, {r4}
> mov pc, lr
> ENDPROC(privcmd_call);
> --
> 1.7.2.5
WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <dave.martin@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"Tim (Xen.org)" <tim@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-dev@lists.linaro.org" <linaro-dev@lists.linaro.org>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH RESEND] xen/arm: use the __HVC macro
Date: Mon, 5 Nov 2012 10:58:17 +0000 [thread overview]
Message-ID: <20121105105817.GC2005@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1210241624400.2689@kaball.uk.xensource.com>
On Wed, Oct 24, 2012 at 04:26:08PM +0100, Stefano Stabellini wrote:
> Use the new __HVC macro in hypercall.S.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
This is correct usage of the __HVC() macro, so
Acked-by: Dave Martin <dave.martin@linaro.org>
> ---
> arch/arm/xen/hypercall.S | 14 +++++---------
> 1 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/xen/hypercall.S b/arch/arm/xen/hypercall.S
> index 074f5ed..71f7239 100644
> --- a/arch/arm/xen/hypercall.S
> +++ b/arch/arm/xen/hypercall.S
> @@ -48,20 +48,16 @@
>
> #include <linux/linkage.h>
> #include <asm/assembler.h>
> +#include <asm/opcodes-virt.h>
> #include <xen/interface/xen.h>
>
>
> -/* HVC 0xEA1 */
> -#ifdef CONFIG_THUMB2_KERNEL
> -#define xen_hvc .word 0xf7e08ea1
> -#else
> -#define xen_hvc .word 0xe140ea71
> -#endif
> +#define XEN_IMM 0xEA1
>
> #define HYPERCALL_SIMPLE(hypercall) \
> ENTRY(HYPERVISOR_##hypercall) \
> mov r12, #__HYPERVISOR_##hypercall; \
> - xen_hvc; \
> + __HVC(XEN_IMM); \
> mov pc, lr; \
> ENDPROC(HYPERVISOR_##hypercall)
>
> @@ -76,7 +72,7 @@ ENTRY(HYPERVISOR_##hypercall) \
> stmdb sp!, {r4} \
> ldr r4, [sp, #4] \
> mov r12, #__HYPERVISOR_##hypercall; \
> - xen_hvc \
> + __HVC(XEN_IMM); \
> ldm sp!, {r4} \
> mov pc, lr \
> ENDPROC(HYPERVISOR_##hypercall)
> @@ -100,7 +96,7 @@ ENTRY(privcmd_call)
> mov r2, r3
> ldr r3, [sp, #8]
> ldr r4, [sp, #4]
> - xen_hvc
> + __HVC(XEN_IMM)
> ldm sp!, {r4}
> mov pc, lr
> ENDPROC(privcmd_call);
> --
> 1.7.2.5
next prev parent reply other threads:[~2012-11-05 10:58 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 15:33 [PATCH v3 00/23] Introduce Xen support on ARM Stefano Stabellini
2012-08-16 15:33 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 01/25] arm: initial Xen support Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 02/25] xen/arm: hypercalls Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 03/25] xen/arm: page.h definitions Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 04/25] xen/arm: sync_bitops Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 05/25] xen/arm: empty implementation of grant_table arch specific functions Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 06/25] docs: Xen ARM DT bindings Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-27 23:03 ` Rob Herring
2012-08-27 23:03 ` Rob Herring
2012-09-12 17:07 ` Stefano Stabellini
2012-09-12 17:07 ` Stefano Stabellini
2012-09-12 17:07 ` Stefano Stabellini
2012-09-12 18:14 ` Stefano Stabellini
2012-09-12 18:14 ` Stefano Stabellini
2012-09-12 18:14 ` Stefano Stabellini
2012-09-13 2:34 ` Rob Herring
2012-09-13 2:34 ` Rob Herring
2012-09-13 10:29 ` Dave Martin
2012-09-13 10:29 ` Dave Martin
2012-09-13 10:29 ` Dave Martin
2012-09-13 11:19 ` Stefano Stabellini
2012-09-13 11:19 ` Stefano Stabellini
2012-09-13 11:19 ` Stefano Stabellini
2012-09-13 11:33 ` Stefano Stabellini
2012-09-13 11:33 ` Stefano Stabellini
2012-09-13 10:26 ` Dave Martin
2012-09-13 10:26 ` Dave Martin
2012-09-13 11:12 ` Stefano Stabellini
2012-09-13 11:12 ` Stefano Stabellini
2012-08-16 15:35 ` [PATCH v3 07/25] xen/arm: Xen detection and shared_info page mapping Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:35 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 08/25] xen/arm: Introduce xen_pfn_t for pfn and mfn types Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 09/25] xen/arm: Introduce xen_ulong_t for unsigned long Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 10/25] xen/arm: compile and run xenbus Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 11/25] xen: do not compile manage, balloon, pci, acpi and cpu_hotplug on ARM Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 12/25] xen/arm: introduce CONFIG_XEN " Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 13/25] xen/arm: get privilege status Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 14/25] xen/arm: initialize grant_table on ARM Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 15/25] xen/arm: receive Xen events " Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 16/25] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 17/25] xen/arm: implement alloc/free_xenballooned_pages with alloc_pages/kfree Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 18/25] xen: allow privcmd for HVM guests Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 19/25] xen/arm: compile blkfront and blkback Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 20/25] xen/arm: compile netback Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 21/25] arm/v2m: initialize arch_timers even if v2m_timer is not present Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 22/25] xen/arm: use the __HVC macro Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 23/25] xen: missing includes Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 24/25] xen: update xen_add_to_physmap interface Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` [PATCH v3 25/25] [HACK] xen/arm: implement xen_remap_domain_mfn_range Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-08-16 15:36 ` Stefano Stabellini
2012-09-13 17:15 ` [PATCH v3 00/23] Introduce Xen support on ARM Stefano Stabellini
2012-09-13 17:15 ` Stefano Stabellini
2012-10-24 15:26 ` [PATCH RESEND] xen/arm: use the __HVC macro Stefano Stabellini
2012-10-24 15:26 ` Stefano Stabellini
2012-10-24 15:26 ` Stefano Stabellini
2012-11-05 10:58 ` Dave Martin [this message]
2012-11-05 10:58 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105105817.GC2005@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.