From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip
Date: Mon, 5 Nov 2012 22:42:26 +0000 [thread overview]
Message-ID: <201211052242.26894.arnd@arndb.de> (raw)
In-Reply-To: <50983422.9090301@gmail.com>
On Monday 05 November 2012, Rob Herring wrote:
> But this should work:
>
> if (!handle_arch_irq)
> handle_arch_irq = fpga_handle_irq;
>
> As long as the primary controller is always initialized first, this will
> work. This is guaranteed by DT of_irq_init, and you will probably have
> other problems if that wasn't the case for non-DT.
How about adding a top-level function in arch/arm that does the assignment
and hides the handle_arch_irq variable:
void set_handle_irq(void (*handle_irq)(struct pt_regs *))
{
if (WARN_ON(handle_arch_irq))
return;
handle_arch_irq = handle_irq;
}
EXPORT_SYMBOL_GPL(set_handle_irq);
Hmm, maybe putting the top-level handler into a loadable module is a bit
far-fetched, but one can hope ;-)
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robherring2@gmail.com>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip
Date: Mon, 5 Nov 2012 22:42:26 +0000 [thread overview]
Message-ID: <201211052242.26894.arnd@arndb.de> (raw)
In-Reply-To: <50983422.9090301@gmail.com>
On Monday 05 November 2012, Rob Herring wrote:
> But this should work:
>
> if (!handle_arch_irq)
> handle_arch_irq = fpga_handle_irq;
>
> As long as the primary controller is always initialized first, this will
> work. This is guaranteed by DT of_irq_init, and you will probably have
> other problems if that wasn't the case for non-DT.
How about adding a top-level function in arch/arm that does the assignment
and hides the handle_arch_irq variable:
void set_handle_irq(void (*handle_irq)(struct pt_regs *))
{
if (WARN_ON(handle_arch_irq))
return;
handle_arch_irq = handle_irq;
}
EXPORT_SYMBOL_GPL(set_handle_irq);
Hmm, maybe putting the top-level handler into a loadable module is a bit
far-fetched, but one can hope ;-)
Arnd
next prev parent reply other threads:[~2012-11-05 22:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 21:28 [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip Linus Walleij
2012-11-01 21:28 ` Linus Walleij
2012-11-01 22:20 ` Thomas Petazzoni
2012-11-01 22:20 ` Thomas Petazzoni
2012-11-02 12:15 ` Russell King - ARM Linux
2012-11-02 12:15 ` Russell King - ARM Linux
2012-11-05 21:48 ` Rob Herring
2012-11-05 21:48 ` Rob Herring
2012-11-05 22:42 ` Arnd Bergmann [this message]
2012-11-05 22:42 ` Arnd Bergmann
2012-11-05 23:14 ` Russell King - ARM Linux
2012-11-05 23:14 ` Russell King - ARM Linux
2012-11-06 14:38 ` Arnd Bergmann
2012-11-06 14:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211052242.26894.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.