* RE: Build failure: OMAP4430 failed due to exynos4 pinctrl
@ 2012-11-12 10:20 Kukjin Kim
2012-11-12 14:40 ` Arnd Bergmann
0 siblings, 1 reply; 9+ messages in thread
From: Kukjin Kim @ 2012-11-12 10:20 UTC (permalink / raw)
To: 'Russell King - ARM Linux', linux-arm-kernel, arm,
'Linus Walleij'
Cc: kgene.kim, linux-samsung-soc
Russell King - ARM Linux wrote:
>
> Last night's randconfig for OMAP4430 failed with:
>
> drivers/built-in.o:(.rodata+0x1a60): undefined reference to
> `exynos4210_pin_ctrl'
>
> Config and log:
> http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2693
> http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2693
Oops, yeah right.
Thanks for pointing out :-)
Please test again with following?...
(+ Linus Walleij)
8<-------------------------------------------------------------
From: Kukjin Kim <kgene.kim@samsung.com>
Subject: [PATCH] pinctrl/samsung: adds dependency for pinctrl-samsung/exynos
The pinctrl-exynos should be built with ARCH_EXYNOS and pinctrl-samsung
should be built with pinctrl-exynos. If not, following error can be
happened.
drivers/built-in.o:(.rodata+0x1a60): undefined reference to
'exynos4210_pin_ctrl'
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
drivers/pinctrl/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 7bf914d..18b473b 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -179,11 +179,13 @@ config PINCTRL_COH901
config PINCTRL_SAMSUNG
bool "Samsung pinctrl driver"
+ depends on PLAT_SAMSUNG
select PINMUX
select PINCONF
config PINCTRL_EXYNOS4
bool "Pinctrl driver data for Exynos4 SoC"
+ depends on PINCTRL_SAMSUNG && ARCH_EXYNOS4
select PINCTRL_SAMSUNG
config PINCTRL_MVEBU
--
1.7.4.1
8<-------------------------------------------------------------
Note, this is a re-sending due to failure of delivery... :-(
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: Build failure: OMAP4430 failed due to exynos4 pinctrl
2012-11-12 10:20 Build failure: OMAP4430 failed due to exynos4 pinctrl Kukjin Kim
@ 2012-11-12 14:40 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2012-11-12 14:40 UTC (permalink / raw)
To: Kukjin Kim
Cc: 'Russell King - ARM Linux', linux-arm-kernel, arm,
'Linus Walleij', linux-samsung-soc
On Monday 12 November 2012, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> >
> > Last night's randconfig for OMAP4430 failed with:
> >
> > drivers/built-in.o:(.rodata+0x1a60): undefined reference to
> > `exynos4210_pin_ctrl'
> >
> > Config and log:
> > http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2693
> > http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2693
>
> Oops, yeah right.
Hmm, I found the same thing earlier and it got lost in my backlog of unsubmitted
patches.
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 7bf914d..18b473b 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -179,11 +179,13 @@ config PINCTRL_COH901
>
> config PINCTRL_SAMSUNG
> bool "Samsung pinctrl driver"
> + depends on PLAT_SAMSUNG
> select PINMUX
> select PINCONF
>
> config PINCTRL_EXYNOS4
> bool "Pinctrl driver data for Exynos4 SoC"
> + depends on PINCTRL_SAMSUNG && ARCH_EXYNOS4
> select PINCTRL_SAMSUNG
This won't work. A driver can't "select" and "depend on"
another symbol at the same time.
This is what I came up with earlier.
Arnd
8<----------------
>From a15cc6277a3a43c8b5c1dd90ca71732b2ffe2b18 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 10 Oct 2012 13:31:45 +0000
Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung
standalone
The main samsung pinctrl module references the specific exynos4210
pinctrl driver, which selects the main driver in Kconfig.
Making the main driver a silent "bool" option avoid this potential
build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n:
drivers/built-in.o:(.rodata+0x4e4): undefined reference to `exynos4210_pin_ctrl'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 7bf914d..9f54bd4 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -178,7 +178,7 @@ config PINCTRL_COH901
ports of 8 GPIO pins each.
config PINCTRL_SAMSUNG
- bool "Samsung pinctrl driver"
+ bool
select PINMUX
select PINCONF
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Build failure: OMAP4430 failed due to exynos4 pinctrl
@ 2012-11-12 14:40 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2012-11-12 14:40 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 12 November 2012, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> >
> > Last night's randconfig for OMAP4430 failed with:
> >
> > drivers/built-in.o:(.rodata+0x1a60): undefined reference to
> > `exynos4210_pin_ctrl'
> >
> > Config and log:
> > http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2693
> > http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2693
>
> Oops, yeah right.
Hmm, I found the same thing earlier and it got lost in my backlog of unsubmitted
patches.
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 7bf914d..18b473b 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -179,11 +179,13 @@ config PINCTRL_COH901
>
> config PINCTRL_SAMSUNG
> bool "Samsung pinctrl driver"
> + depends on PLAT_SAMSUNG
> select PINMUX
> select PINCONF
>
> config PINCTRL_EXYNOS4
> bool "Pinctrl driver data for Exynos4 SoC"
> + depends on PINCTRL_SAMSUNG && ARCH_EXYNOS4
> select PINCTRL_SAMSUNG
This won't work. A driver can't "select" and "depend on"
another symbol at the same time.
This is what I came up with earlier.
Arnd
8<----------------
>From a15cc6277a3a43c8b5c1dd90ca71732b2ffe2b18 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 10 Oct 2012 13:31:45 +0000
Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung
standalone
The main samsung pinctrl module references the specific exynos4210
pinctrl driver, which selects the main driver in Kconfig.
Making the main driver a silent "bool" option avoid this potential
build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n:
drivers/built-in.o:(.rodata+0x4e4): undefined reference to `exynos4210_pin_ctrl'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 7bf914d..9f54bd4 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -178,7 +178,7 @@ config PINCTRL_COH901
ports of 8 GPIO pins each.
config PINCTRL_SAMSUNG
- bool "Samsung pinctrl driver"
+ bool
select PINMUX
select PINCONF
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: Build failure: OMAP4430 failed due to exynos4 pinctrl
2012-11-12 14:40 ` Arnd Bergmann
@ 2012-11-13 5:11 ` Kukjin Kim
-1 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-11-13 5:11 UTC (permalink / raw)
To: 'Arnd Bergmann'
Cc: 'Russell King - ARM Linux', linux-arm-kernel, arm,
'Linus Walleij', linux-samsung-soc
Arnd Bergmann wrote:
>
[...]
> This won't work. A driver can't "select" and "depend on"
> another symbol at the same time.
>
Ooooops. You're right. I missed :-(
> This is what I came up with earlier.
>
> Arnd
> 8<----------------
> From a15cc6277a3a43c8b5c1dd90ca71732b2ffe2b18 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Wed, 10 Oct 2012 13:31:45 +0000
> Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung
> standalone
>
> The main samsung pinctrl module references the specific exynos4210
> pinctrl driver, which selects the main driver in Kconfig.
>
> Making the main driver a silent "bool" option avoid this potential
> build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n:
>
> drivers/built-in.o:(.rodata+0x4e4): undefined reference to
> `exynos4210_pin_ctrl'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Linus, can you pick this up in your pinctrl/fixes ree?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 7bf914d..9f54bd4 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -178,7 +178,7 @@ config PINCTRL_COH901
> ports of 8 GPIO pins each.
>
> config PINCTRL_SAMSUNG
> - bool "Samsung pinctrl driver"
> + bool
> select PINMUX
> select PINCONF
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Build failure: OMAP4430 failed due to exynos4 pinctrl
@ 2012-11-13 5:11 ` Kukjin Kim
0 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-11-13 5:11 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann wrote:
>
[...]
> This won't work. A driver can't "select" and "depend on"
> another symbol at the same time.
>
Ooooops. You're right. I missed :-(
> This is what I came up with earlier.
>
> Arnd
> 8<----------------
> From a15cc6277a3a43c8b5c1dd90ca71732b2ffe2b18 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Wed, 10 Oct 2012 13:31:45 +0000
> Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung
> standalone
>
> The main samsung pinctrl module references the specific exynos4210
> pinctrl driver, which selects the main driver in Kconfig.
>
> Making the main driver a silent "bool" option avoid this potential
> build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n:
>
> drivers/built-in.o:(.rodata+0x4e4): undefined reference to
> `exynos4210_pin_ctrl'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Linus, can you pick this up in your pinctrl/fixes ree?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 7bf914d..9f54bd4 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -178,7 +178,7 @@ config PINCTRL_COH901
> ports of 8 GPIO pins each.
>
> config PINCTRL_SAMSUNG
> - bool "Samsung pinctrl driver"
> + bool
> select PINMUX
> select PINCONF
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Build failure: OMAP4430 failed due to exynos4 pinctrl
2012-11-13 5:11 ` Kukjin Kim
@ 2012-11-15 10:59 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2012-11-15 10:59 UTC (permalink / raw)
To: Kukjin Kim
Cc: Arnd Bergmann, Russell King - ARM Linux, linux-arm-kernel, arm,
linux-samsung-soc
On Tue, Nov 13, 2012 at 6:11 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> Date: Wed, 10 Oct 2012 13:31:45 +0000
>> Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung
>> standalone
>>
>> The main samsung pinctrl module references the specific exynos4210
>> pinctrl driver, which selects the main driver in Kconfig.
>>
>> Making the main driver a silent "bool" option avoid this potential
>> build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n:
>>
>> drivers/built-in.o:(.rodata+0x4e4): undefined reference to
>> `exynos4210_pin_ctrl'
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Tomasz Figa <t.figa@samsung.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Kukjin Kim <kgene.kim@samsung.com>
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
>
> Linus, can you pick this up in your pinctrl/fixes ree?
OK done.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Build failure: OMAP4430 failed due to exynos4 pinctrl
@ 2012-11-15 10:59 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2012-11-15 10:59 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 13, 2012 at 6:11 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> Date: Wed, 10 Oct 2012 13:31:45 +0000
>> Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung
>> standalone
>>
>> The main samsung pinctrl module references the specific exynos4210
>> pinctrl driver, which selects the main driver in Kconfig.
>>
>> Making the main driver a silent "bool" option avoid this potential
>> build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n:
>>
>> drivers/built-in.o:(.rodata+0x4e4): undefined reference to
>> `exynos4210_pin_ctrl'
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Tomasz Figa <t.figa@samsung.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Kukjin Kim <kgene.kim@samsung.com>
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
>
> Linus, can you pick this up in your pinctrl/fixes ree?
OK done.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Build failure: OMAP4430 failed due to exynos4 pinctrl
@ 2012-11-12 9:33 Russell King - ARM Linux
2012-11-12 10:02 ` Kukjin Kim
0 siblings, 1 reply; 9+ messages in thread
From: Russell King - ARM Linux @ 2012-11-12 9:33 UTC (permalink / raw)
To: linux-arm-kernel
Last night's randconfig for OMAP4430 failed with:
drivers/built-in.o:(.rodata+0x1a60): undefined reference to `exynos4210_pin_ctrl'
Config and log:
http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2693
http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2693
^ permalink raw reply [flat|nested] 9+ messages in thread
* Build failure: OMAP4430 failed due to exynos4 pinctrl
2012-11-12 9:33 Russell King - ARM Linux
@ 2012-11-12 10:02 ` Kukjin Kim
0 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2012-11-12 10:02 UTC (permalink / raw)
To: linux-arm-kernel
Russell King - ARM Linux wrote:
>
> Last night's randconfig for OMAP4430 failed with:
>
> drivers/built-in.o:(.rodata+0x1a60): undefined reference to
> `exynos4210_pin_ctrl'
>
> Config and log:
> http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=2693
> http://www.arm.linux.org.uk/developer/build/result.php?type=build&idx=2693
Oops, yeah right.
Thanks for pointing out :-)
Please test again with following?...
(+ Linus Walleij)
8<-------------------------------------------------------------
From: Kukjin Kim <kgene.kim@samsung.com>
Subject: [PATCH] pinctrl/samsung: adds dependency for pinctrl-samsung/exynos
The pinctrl-exynos should be built with ARCH_EXYNOS and pinctrl-samsung
should be built with pinctrl-exynos. If not, following error can be
happened.
drivers/built-in.o:(.rodata+0x1a60): undefined reference to
'exynos4210_pin_ctrl'
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
drivers/pinctrl/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 7bf914d..18b473b 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -179,11 +179,13 @@ config PINCTRL_COH901
config PINCTRL_SAMSUNG
bool "Samsung pinctrl driver"
+ depends on PLAT_SAMSUNG
select PINMUX
select PINCONF
config PINCTRL_EXYNOS4
bool "Pinctrl driver data for Exynos4 SoC"
+ depends on PINCTRL_SAMSUNG && ARCH_EXYNOS4
select PINCTRL_SAMSUNG
config PINCTRL_MVEBU
--
1.7.4.1
8<-------------------------------------------------------------
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-11-15 10:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-12 10:20 Build failure: OMAP4430 failed due to exynos4 pinctrl Kukjin Kim
2012-11-12 14:40 ` Arnd Bergmann
2012-11-12 14:40 ` Arnd Bergmann
2012-11-13 5:11 ` Kukjin Kim
2012-11-13 5:11 ` Kukjin Kim
2012-11-15 10:59 ` Linus Walleij
2012-11-15 10:59 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2012-11-12 9:33 Russell King - ARM Linux
2012-11-12 10:02 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.