From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jacek Konieczny <jajcus@jajcus.net>
Subject: Re: [PATCH] Fix locking in tools/hotplug/Linux/locking.sh
Date: Mon, 12 Nov 2012 19:07:38 +0100 [thread overview]
Message-ID: <20121112180738.GA26672@aepfle.de> (raw)
In-Reply-To: <1352738557.27833.302.camel@zakaz.uk.xensource.com>
On Mon, Nov 12, Ian Campbell wrote:
> On Fri, 2012-11-09 at 13:56 +0000, Jacek Konieczny wrote:
> > The claim_lock() function would fail in the perl code with:
> >
> > Invalid argument at -e line 2.
> >
> > because the Perl snippet opens for reading the file descriptor, which
> > was earlier opened for write (append).
>
> Looks plausible to me.
>
> How does this interact with the
> eval "exec $_lockfd<&-"
> which Olaf added in 26079:b3b03536789a ? I suppose close is close and
> <&- and >&- or even <>&- are equivalent?
I did not see the perl error, in what environment did you notice this
error?
Olaf
next prev parent reply other threads:[~2012-11-12 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 13:56 [PATCH] Fix locking in tools/hotplug/Linux/locking.sh Jacek Konieczny
2012-11-12 16:42 ` Ian Campbell
2012-11-12 18:05 ` Jacek Konieczny
2012-11-12 18:07 ` Olaf Hering [this message]
2012-11-12 18:34 ` Jacek Konieczny
2012-11-12 18:40 ` Olaf Hering
2012-11-13 11:08 ` Ian Campbell
2012-11-13 13:27 ` Jacek Konieczny
2012-11-13 16:21 ` Ian Jackson
2012-11-13 16:25 ` Ian Campbell
2012-11-14 10:24 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112180738.GA26672@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jajcus@jajcus.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.