From: Dave Chinner <david@fromorbit.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
linux list <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: xfs: Remove boolean_t typedef completely.
Date: Tue, 13 Nov 2012 12:53:18 +1100 [thread overview]
Message-ID: <20121113015318.GD25039@dastard> (raw)
In-Reply-To: <CACnwZYd2kPaK1urLYc8BBuuqD7_Oo1oF+KvqWYj7DAEGy6grHQ@mail.gmail.com>
On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote:
> On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote:
> >> Hi,
> >>
> >> Please, take a look.
> >>
> >> Patch attached.
> >
> > It's a good start for a cleanup, but there's no point in removing
> > the boolean_t from one file and then not removing it from the rest
> > of the XFS code. It's only used in a handful of places, so just
> > remove it completely.
> >
> Done.
>
> Please, take another look.
>
> > Also, can you please place patches in line rather than attaching
> > them. Attaching them means they cannot be quoted in reply. See
> > Documentation/SubmittingPatches and Documentation/email-clients.txt
> > for guidelines.
> >
> Sorry, patch attached.
It's still attached as a base64 encoded attachment, not as inline
text....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux list <linux-kernel@vger.kernel.org>,
Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
xfs@oss.sgi.com
Subject: Re: xfs: Remove boolean_t typedef completely.
Date: Tue, 13 Nov 2012 12:53:18 +1100 [thread overview]
Message-ID: <20121113015318.GD25039@dastard> (raw)
In-Reply-To: <CACnwZYd2kPaK1urLYc8BBuuqD7_Oo1oF+KvqWYj7DAEGy6grHQ@mail.gmail.com>
On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote:
> On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote:
> >> Hi,
> >>
> >> Please, take a look.
> >>
> >> Patch attached.
> >
> > It's a good start for a cleanup, but there's no point in removing
> > the boolean_t from one file and then not removing it from the rest
> > of the XFS code. It's only used in a handful of places, so just
> > remove it completely.
> >
> Done.
>
> Please, take another look.
>
> > Also, can you please place patches in line rather than attaching
> > them. Attaching them means they cannot be quoted in reply. See
> > Documentation/SubmittingPatches and Documentation/email-clients.txt
> > for guidelines.
> >
> Sorry, patch attached.
It's still attached as a base64 encoded attachment, not as inline
text....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-11-13 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 0:36 xfs: Remove boolean_t typedef completely Thiago Farina
2012-11-13 0:36 ` Thiago Farina
2012-11-13 1:53 ` Dave Chinner [this message]
2012-11-13 1:53 ` Dave Chinner
2012-11-13 2:02 ` Thiago Farina
2012-11-13 2:02 ` Thiago Farina
2012-11-13 2:32 ` Ben Myers
2012-11-13 2:32 ` Ben Myers
2012-11-13 15:16 ` Thiago Farina
2012-11-13 15:24 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113015318.GD25039@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tfransosi@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.