From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: plagnioj@jcrosoft.com, nicolas.ferre@atmel.com,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org, linux-sound@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v5 2/3] ASoC: atmel-ssc-dai: register dai and pcm directly
Date: Tue, 13 Nov 2012 17:30:33 +0900 [thread overview]
Message-ID: <20121113083031.GP18224@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352706028-750-3-git-send-email-voice.shen@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Mon, Nov 12, 2012 at 03:40:26PM +0800, Bo Shen wrote:
> static struct platform_device sam9g20ek_audio_device = {
> .name = "at91sam9g20ek-audio",
> - .id = -1,
> + .id = 0,
> };
Why are you changing this? Single devices are supposed to specify -1 as
their id.
> static int atmel_ssc_startup(struct snd_pcm_substream *substream,
> struct snd_soc_dai *dai)
> {
> - struct atmel_ssc_info *ssc_p = &ssc_info[dai->id];
> + struct atmel_ssc_info *ssc_p = &ssc_info;
This seems like a very big step backwards, there's now a single global
variable for the ssc_info which presumably means there can be only one
SSC active in the system at once. That's changing a lot more than just
the registration...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: plagnioj@jcrosoft.com, nicolas.ferre@atmel.com,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org, linux-sound@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v5 2/3] ASoC: atmel-ssc-dai: register dai and pcm directly
Date: Tue, 13 Nov 2012 08:30:33 +0000 [thread overview]
Message-ID: <20121113083031.GP18224@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352706028-750-3-git-send-email-voice.shen@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Mon, Nov 12, 2012 at 03:40:26PM +0800, Bo Shen wrote:
> static struct platform_device sam9g20ek_audio_device = {
> .name = "at91sam9g20ek-audio",
> - .id = -1,
> + .id = 0,
> };
Why are you changing this? Single devices are supposed to specify -1 as
their id.
> static int atmel_ssc_startup(struct snd_pcm_substream *substream,
> struct snd_soc_dai *dai)
> {
> - struct atmel_ssc_info *ssc_p = &ssc_info[dai->id];
> + struct atmel_ssc_info *ssc_p = &ssc_info;
This seems like a very big step backwards, there's now a single global
variable for the ssc_info which presumably means there can be only one
SSC active in the system at once. That's changing a lot more than just
the registration...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/3] ASoC: atmel-ssc-dai: register dai and pcm directly
Date: Tue, 13 Nov 2012 17:30:33 +0900 [thread overview]
Message-ID: <20121113083031.GP18224@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352706028-750-3-git-send-email-voice.shen@atmel.com>
On Mon, Nov 12, 2012 at 03:40:26PM +0800, Bo Shen wrote:
> static struct platform_device sam9g20ek_audio_device = {
> .name = "at91sam9g20ek-audio",
> - .id = -1,
> + .id = 0,
> };
Why are you changing this? Single devices are supposed to specify -1 as
their id.
> static int atmel_ssc_startup(struct snd_pcm_substream *substream,
> struct snd_soc_dai *dai)
> {
> - struct atmel_ssc_info *ssc_p = &ssc_info[dai->id];
> + struct atmel_ssc_info *ssc_p = &ssc_info;
This seems like a very big step backwards, there's now a single global
variable for the ssc_info which presumably means there can be only one
SSC active in the system at once. That's changing a lot more than just
the registration...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121113/c38c8800/attachment.sig>
next prev parent reply other threads:[~2012-11-13 8:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 7:40 [PATCH v5 0/3] Add pinctrl support and enable audio Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-12 7:40 ` [PATCH v5 1/3] ARM: at91: atmel-ssc: add pinctrl support Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-13 8:50 ` Mark Brown
2012-11-13 8:50 ` Mark Brown
2012-11-13 8:50 ` Mark Brown
[not found] ` <20121113085052.GR18224-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-14 6:30 ` Bo Shen
2012-11-14 6:30 ` Bo Shen
2012-11-14 6:30 ` Bo Shen
2012-11-12 7:40 ` [PATCH v5 2/3] ASoC: atmel-ssc-dai: register dai and pcm directly Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-13 8:30 ` Mark Brown [this message]
2012-11-13 8:30 ` Mark Brown
2012-11-13 8:30 ` Mark Brown
2012-11-13 9:10 ` Bo Shen
2012-11-13 9:10 ` Bo Shen
2012-11-13 9:10 ` Bo Shen
2012-11-13 9:20 ` Mark Brown
2012-11-13 9:20 ` Mark Brown
2012-11-13 9:20 ` Mark Brown
2012-11-13 9:38 ` Bo Shen
2012-11-13 9:38 ` Bo Shen
2012-11-13 9:38 ` Bo Shen
2012-11-13 9:41 ` Mark Brown
2012-11-13 9:41 ` Mark Brown
2012-11-13 9:41 ` Mark Brown
2012-11-13 9:52 ` Bo Shen
2012-11-13 9:52 ` Bo Shen
2012-11-13 9:52 ` Bo Shen
2012-11-12 7:40 ` [PATCH 3/3] ASoC: at91sam9g20ek-wm8731: convert to dt support Bo Shen
2012-11-12 7:40 ` Bo Shen
2012-11-12 7:40 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113083031.GP18224@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.