From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes
Date: Tue, 13 Nov 2012 12:50:02 -0800 [thread overview]
Message-ID: <20121113205002.GA27716@kroah.com> (raw)
In-Reply-To: <1352648485.6460.16.camel@canaries32-MCP7A>
On Sun, Nov 11, 2012 at 03:41:25PM +0000, Malcolm Priestley wrote:
>
> After this patch all BYTE/WORD/DWORD types can be replaced with the appropriate u sizes.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
> drivers/staging/vt6656/ttype.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h
> index 0f70562c..dfbf747 100644
> --- a/drivers/staging/vt6656/ttype.h
> +++ b/drivers/staging/vt6656/ttype.h
> @@ -44,9 +44,9 @@ typedef int BOOL;
>
> /****** Simple typedefs ***************************************************/
>
> -typedef unsigned char BYTE; // 8-bit
> -typedef unsigned short WORD; // 16-bit
> -typedef unsigned long DWORD; // 32-bit
> +typedef u8 BYTE;
> +typedef u16 WORD;
> +typedef u32 DWORD;
That's good, but in the end, we want to get rid of BYTE, WORD, and DWORD
usages in this driver, can you just start replacing them with the proper
types?
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-13 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 15:41 [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes Malcolm Priestley
2012-11-13 20:50 ` Greg KH [this message]
2012-11-13 20:50 ` Greg KH
2012-11-13 21:30 ` Malcolm Priestley
2012-11-13 21:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113205002.GA27716@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.