All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes
Date: Tue, 13 Nov 2012 13:51:35 -0800	[thread overview]
Message-ID: <20121113215135.GA16020@kroah.com> (raw)
In-Reply-To: <1352842218.8169.11.camel@user64-MCP7A>

On Tue, Nov 13, 2012 at 09:30:18PM +0000, Malcolm Priestley wrote:
> On Tue, 2012-11-13 at 12:50 -0800, Greg KH wrote:
> > On Sun, Nov 11, 2012 at 03:41:25PM +0000, Malcolm Priestley wrote:
> > >  /****** Common pointer types ***********************************************/
> > >  
> > > -typedef unsigned long   ULONG_PTR;      // 32-bit
> > > -typedef unsigned long   DWORD_PTR;      // 32-bit
> > > +typedef u32 ULONG_PTR;
> > > +typedef u32 DWORD_PTR;
> > 
> > A pointer does not fit in u32 on all arches, only unsigned long works
> > here.
> > 
> Hi
> 
> The naming is misleading, they are not pointers.

Ah, but of course :)

> I have a upcoming patch to remove them.

Ok, that sounds good.

greg k-h

      reply	other threads:[~2012-11-13 21:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-11 15:41 [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes Malcolm Priestley
2012-11-13 20:50 ` Greg KH
2012-11-13 20:50 ` Greg KH
2012-11-13 21:30   ` Malcolm Priestley
2012-11-13 21:51     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121113215135.GA16020@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.