From: Felipe Balbi <balbi@ti.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
Thomas Dahlmann <dahlmann.thomas@arcor.de>,
Felipe Balbi <balbi@ti.com>, Krzysztof Halasa <khc@pm.waw.pl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-geode@lists.infradead.org
Subject: Re: [PATCH v2] mm: fix null dev in dma_pool_create()
Date: Wed, 14 Nov 2012 16:17:42 +0200 [thread overview]
Message-ID: <20121114141742.GC24736@arwen.pp.htv.fi> (raw)
In-Reply-To: <50A3313D.1000809@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Hi,
On Wed, Nov 14, 2012 at 12:50:53AM -0500, Xi Wang wrote:
> * drivers/usb/gadget/amd5536udc.c (2)
>
> Use dev->gadget.dev or dev->pdev->dev for dma_pool_create()? Also move
> the init_dma_pools() call after the assignments in udc_pci_probe().
Makes sense to me. Do you want to provide a patch ? Make sure to Cc
myself and linux-usb ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Thomas Dahlmann <dahlmann.thomas@arcor.de>,
Felipe Balbi <balbi@ti.com>, Krzysztof Halasa <khc@pm.waw.pl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-geode@lists.infradead.org>
Subject: Re: [PATCH v2] mm: fix null dev in dma_pool_create()
Date: Wed, 14 Nov 2012 16:17:42 +0200 [thread overview]
Message-ID: <20121114141742.GC24736@arwen.pp.htv.fi> (raw)
In-Reply-To: <50A3313D.1000809@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Hi,
On Wed, Nov 14, 2012 at 12:50:53AM -0500, Xi Wang wrote:
> * drivers/usb/gadget/amd5536udc.c (2)
>
> Use dev->gadget.dev or dev->pdev->dev for dma_pool_create()? Also move
> the init_dma_pools() call after the assignments in udc_pci_probe().
Makes sense to me. Do you want to provide a patch ? Make sure to Cc
myself and linux-usb ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-14 14:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 6:46 [PATCH] mm: fix NULL checking in dma_pool_create() Xi Wang
2012-11-05 6:46 ` Xi Wang
2012-11-05 20:37 ` Andrew Morton
2012-11-05 20:37 ` Andrew Morton
2012-11-05 20:50 ` Xi Wang
2012-11-05 20:50 ` Xi Wang
2012-11-05 21:26 ` Andrew Morton
2012-11-05 21:26 ` Andrew Morton
2012-11-06 20:48 ` Xi Wang
2012-11-06 20:48 ` Xi Wang
2012-11-13 21:39 ` [PATCH v2] mm: fix null dev " Xi Wang
2012-11-13 21:39 ` Xi Wang
2012-11-13 23:01 ` David Rientjes
2012-11-13 23:01 ` David Rientjes
2012-11-14 0:47 ` Andrew Morton
2012-11-14 0:47 ` Andrew Morton
2012-11-14 0:58 ` Andrew Morton
2012-11-14 0:58 ` Andrew Morton
2012-11-14 5:50 ` Xi Wang
2012-11-14 5:50 ` Xi Wang
2012-11-14 14:17 ` Felipe Balbi [this message]
2012-11-14 14:17 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114141742.GC24736@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=akpm@linux-foundation.org \
--cc=dahlmann.thomas@arcor.de \
--cc=gregkh@linuxfoundation.org \
--cc=kgene.kim@samsung.com \
--cc=khc@pm.waw.pl \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.