From: mgr@pengutronix.de (Michael Grzeschik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] usb: chipidea: usbmisc: add support for ahb, ipg and per clock
Date: Wed, 14 Nov 2012 16:27:40 +0100 [thread overview]
Message-ID: <20121114152740.GA13387@pengutronix.de> (raw)
In-Reply-To: <87mwyk718g.fsf@ashishki-desk.ger.corp.intel.com>
On Wed, Nov 14, 2012 at 03:39:11PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik <m.grzeschik@pengutronix.de> writes:
>
> > From: Marc Kleine-Budde <mkl@pengutronix.de>
> >
> > This patch adds support for ahb, ipg and per clock, which is needed to support
> > imx53.
>
> I would also suggest using a more elaborate wording here, some people
> might also be interested what are the different clocks for (like,
> interface, peripheral, etc etc).
>
Will do in V2.
> >
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> > drivers/usb/chipidea/usbmisc_imx.c | 60 +++++++++++++++++++++++++++---------
> > 1 file changed, 45 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> > index 72445f7..239b752 100644
> > --- a/drivers/usb/chipidea/usbmisc_imx.c
> > +++ b/drivers/usb/chipidea/usbmisc_imx.c
> > @@ -24,7 +24,9 @@
> > struct imx_usbmisc {
> > void __iomem *base;
> > spinlock_t lock;
> > - struct clk *clk;
> > + struct clk *clk_ahb;
> > + struct clk *clk_ipg;
> > + struct clk *clk_per;
> > struct usbmisc_usb_device usbdev[USB_DEV_MAX];
> > const struct usbmisc_ops *ops;
> > };
> > @@ -104,38 +106,66 @@ static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
> > if (!data->base)
> > return -EADDRNOTAVAIL;
> >
> > - data->clk = devm_clk_get(&pdev->dev, NULL);
> > - if (IS_ERR(data->clk)) {
> > + data->clk_ahb = devm_clk_get(&pdev->dev, "ahb");
>
> I suppose the clock names are also being added/changed in the platform
> code in another patchset that's also being queued? What's the target
> merge window (if there's a dependency)?
Yes we have more branches to be published next. One of them is
adding the usb device tree nodes and clock entries for mx53.
Thanks,
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Michael Grzeschik <mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Alexander Shishkin
<alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Michael Grzeschik
<m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 4/6] usb: chipidea: usbmisc: add support for ahb, ipg and per clock
Date: Wed, 14 Nov 2012 16:27:40 +0100 [thread overview]
Message-ID: <20121114152740.GA13387@pengutronix.de> (raw)
In-Reply-To: <87mwyk718g.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
On Wed, Nov 14, 2012 at 03:39:11PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> writes:
>
> > From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >
> > This patch adds support for ahb, ipg and per clock, which is needed to support
> > imx53.
>
> I would also suggest using a more elaborate wording here, some people
> might also be interested what are the different clocks for (like,
> interface, peripheral, etc etc).
>
Will do in V2.
> >
> > Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> > drivers/usb/chipidea/usbmisc_imx.c | 60 +++++++++++++++++++++++++++---------
> > 1 file changed, 45 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> > index 72445f7..239b752 100644
> > --- a/drivers/usb/chipidea/usbmisc_imx.c
> > +++ b/drivers/usb/chipidea/usbmisc_imx.c
> > @@ -24,7 +24,9 @@
> > struct imx_usbmisc {
> > void __iomem *base;
> > spinlock_t lock;
> > - struct clk *clk;
> > + struct clk *clk_ahb;
> > + struct clk *clk_ipg;
> > + struct clk *clk_per;
> > struct usbmisc_usb_device usbdev[USB_DEV_MAX];
> > const struct usbmisc_ops *ops;
> > };
> > @@ -104,38 +106,66 @@ static int __devinit usbmisc_imx_probe(struct platform_device *pdev)
> > if (!data->base)
> > return -EADDRNOTAVAIL;
> >
> > - data->clk = devm_clk_get(&pdev->dev, NULL);
> > - if (IS_ERR(data->clk)) {
> > + data->clk_ahb = devm_clk_get(&pdev->dev, "ahb");
>
> I suppose the clock names are also being added/changed in the platform
> code in another patchset that's also being queued? What's the target
> merge window (if there's a dependency)?
Yes we have more branches to be published next. One of them is
adding the usb device tree nodes and clock entries for mx53.
Thanks,
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-14 15:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 11:55 [PATCH 0/6] support other fsl SoCs with usbmisc + small fixes Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-14 11:55 ` [PATCH 1/6] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-14 13:22 ` Alexander Shishkin
2012-11-14 13:22 ` Alexander Shishkin
2012-11-14 11:55 ` [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-14 11:57 ` Fabio Estevam
2012-11-14 11:57 ` Fabio Estevam
2012-11-14 15:32 ` Michael Grzeschik
2012-11-14 15:32 ` Michael Grzeschik
2012-11-14 13:25 ` Alexander Shishkin
2012-11-14 13:25 ` Alexander Shishkin
2012-11-14 13:28 ` Michael Grzeschik
2012-11-14 13:28 ` Michael Grzeschik
2012-11-14 13:32 ` Alexander Shishkin
2012-11-14 13:32 ` Alexander Shishkin
2012-11-14 11:55 ` [PATCH 3/6] usb: chipidea: usbmisc: prepare driver to handle more than one soc Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-14 11:55 ` [PATCH 4/6] usb: chipidea: usbmisc: add support for ahb, ipg and per clock Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-14 13:39 ` Alexander Shishkin
2012-11-14 13:39 ` Alexander Shishkin
2012-11-14 15:27 ` Michael Grzeschik [this message]
2012-11-14 15:27 ` Michael Grzeschik
2012-11-14 11:55 ` [PATCH 5/6] usb: chipidea: usbmisc: add mx53 support Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-14 11:55 ` [PATCH 6/6] usb: chipidea: usbmisc: add post handling and errata fix for mx25 Michael Grzeschik
2012-11-14 11:55 ` Michael Grzeschik
2012-11-15 10:08 ` Martin Fuzzey
2012-11-15 10:08 ` Martin Fuzzey
2012-11-15 10:25 ` Michael Grzeschik
2012-11-15 10:25 ` Michael Grzeschik
2012-11-15 13:51 ` Martin Fuzzey
2012-11-15 13:51 ` Martin Fuzzey
2012-11-15 13:54 ` Marc Kleine-Budde
2012-11-15 13:54 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114152740.GA13387@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.