All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Michal Hocko <mhocko@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Ying Han <yinghan@google.com>
Subject: Re: [RFC] rework mem_cgroup iterator
Date: Wed, 14 Nov 2012 10:41:10 -0800	[thread overview]
Message-ID: <20121114184110.GD21185@mtj.dyndns.org> (raw)
In-Reply-To: <50A3C42F.9020901@parallels.com>

Hello, Glauber.

On Wed, Nov 14, 2012 at 05:17:51PM +0100, Glauber Costa wrote:
> Why can't we reuse the scheduler iterator and move it to kernel/cgroup.c
> ? It already exists, provide sane ordering, and only relies on parent
> information - which cgroup core already have - to do the walk.

Hmmm... we can but I personally much prefer for_each_*() iterators
over callback based ones.  It's just much easier to share states
across an iteration and follow the logic.  walk_tg_tree_from() does
have the benefit of being able to combine pre and post visits in the
same walk, which doesn't seem to have any user at the moment.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <htejun@gmail.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Michal Hocko <mhocko@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Ying Han <yinghan@google.com>
Subject: Re: [RFC] rework mem_cgroup iterator
Date: Wed, 14 Nov 2012 10:41:10 -0800	[thread overview]
Message-ID: <20121114184110.GD21185@mtj.dyndns.org> (raw)
In-Reply-To: <50A3C42F.9020901@parallels.com>

Hello, Glauber.

On Wed, Nov 14, 2012 at 05:17:51PM +0100, Glauber Costa wrote:
> Why can't we reuse the scheduler iterator and move it to kernel/cgroup.c
> ? It already exists, provide sane ordering, and only relies on parent
> information - which cgroup core already have - to do the walk.

Hmmm... we can but I personally much prefer for_each_*() iterators
over callback based ones.  It's just much easier to share states
across an iteration and follow the logic.  walk_tg_tree_from() does
have the benefit of being able to combine pre and post visits in the
same walk, which doesn't seem to have any user at the moment.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-11-14 18:41 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13 15:30 [RFC] rework mem_cgroup iterator Michal Hocko
2012-11-13 15:30 ` Michal Hocko
2012-11-13 15:30 ` [RFC 1/5] memcg: synchronize per-zone iterator access by a spinlock Michal Hocko
2012-11-13 15:30   ` Michal Hocko
2012-11-14  0:03   ` Kamezawa Hiroyuki
2012-11-14  0:03     ` Kamezawa Hiroyuki
2012-11-13 15:30 ` [RFC 2/5] memcg: rework mem_cgroup_iter to use cgroup iterators Michal Hocko
2012-11-13 15:30   ` Michal Hocko
2012-11-13 16:14   ` Tejun Heo
2012-11-13 16:14     ` Tejun Heo
2012-11-14  8:51     ` Michal Hocko
2012-11-14  8:51       ` Michal Hocko
2012-11-14 18:52       ` Tejun Heo
2012-11-14 18:52         ` Tejun Heo
2012-11-15  9:51         ` Michal Hocko
2012-11-15  9:51           ` Michal Hocko
2012-11-15 14:47           ` Tejun Heo
2012-11-15 14:47             ` Tejun Heo
2012-11-15 15:12             ` Michal Hocko
2012-11-15 15:12               ` Michal Hocko
2012-11-15 15:31               ` Tejun Heo
2012-11-15 15:31                 ` Tejun Heo
2012-11-15 16:15                 ` Michal Hocko
2012-11-15 16:15                   ` Michal Hocko
2012-11-14  0:20   ` Kamezawa Hiroyuki
2012-11-14  0:20     ` Kamezawa Hiroyuki
2012-11-14 10:10     ` Michal Hocko
2012-11-14 10:10       ` Michal Hocko
2012-11-15  4:12       ` Kamezawa Hiroyuki
2012-11-15  4:12         ` Kamezawa Hiroyuki
2012-11-15  9:52         ` Michal Hocko
2012-11-15  9:52           ` Michal Hocko
2012-11-19 14:05       ` Michal Hocko
2012-11-19 14:05         ` Michal Hocko
2012-11-19 15:11   ` Michal Hocko
2012-11-19 15:11     ` Michal Hocko
2012-11-13 15:30 ` [RFC 3/5] memcg: simplify mem_cgroup_iter Michal Hocko
2012-11-13 15:30   ` Michal Hocko
2012-11-13 15:30 ` [RFC 4/5] memcg: clean up mem_cgroup_iter Michal Hocko
2012-11-13 15:30   ` Michal Hocko
2012-11-13 15:30 ` [RFC 5/5] cgroup: remove css_get_next Michal Hocko
2012-11-13 15:30   ` Michal Hocko
2012-11-14  0:13 ` [RFC] rework mem_cgroup iterator Kamezawa Hiroyuki
2012-11-14  0:13   ` Kamezawa Hiroyuki
2012-11-14  1:55 ` Li Zefan
2012-11-14  1:55   ` Li Zefan
2012-11-14  8:36   ` Michal Hocko
2012-11-14  8:36     ` Michal Hocko
2012-11-14 18:30     ` Tejun Heo
2012-11-14 18:30       ` Tejun Heo
2012-11-15  2:12   ` Kamezawa Hiroyuki
2012-11-15  2:12     ` Kamezawa Hiroyuki
2012-11-14 16:17 ` Glauber Costa
2012-11-14 16:17   ` Glauber Costa
2012-11-14  8:40   ` Michal Hocko
2012-11-14  8:40     ` Michal Hocko
2012-11-14 18:41   ` Tejun Heo [this message]
2012-11-14 18:41     ` Tejun Heo
2012-11-15  2:44     ` Glauber Costa
2012-11-15  2:44       ` Glauber Costa
2012-11-14 18:46       ` Tejun Heo
2012-11-14 18:46         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121114184110.GD21185@mtj.dyndns.org \
    --to=htejun@gmail.com \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.