From: Andrew Morton <akpm@linux-foundation.org>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, Rob Landley <rob@landley.net>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Liu <jiang.liu@huawei.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Yinghai Lu <yinghai@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Lin feng <linfeng@cn.fujitsu.com>
Subject: Re: [PART3 Patch v2 13/14] page_alloc: use N_MEMORY instead N_HIGH_MEMORY change the node_states initialization
Date: Thu, 15 Nov 2012 16:29:20 -0800 [thread overview]
Message-ID: <20121115162920.af46d08a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352969857-26623-14-git-send-email-wency@cn.fujitsu.com>
On Thu, 15 Nov 2012 16:57:36 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:
> N_HIGH_MEMORY stands for the nodes that has normal or high memory.
> N_MEMORY stands for the nodes that has any memory.
>
> The code here need to handle with the nodes which have memory, we should
> use N_MEMORY instead.
>
> Since we introduced N_MEMORY, we update the initialization of node_states.
reset_zone_present_pages() has been removed by the recently-queued
revert-mm-fix-up-zone-present-pages.patch, so I dropped that hunk.
We still have
akpm:/usr/src/25> grep N_HIGH_MEMORY mm/page_alloc.c
[N_HIGH_MEMORY] = { { [0] = 1UL } },
node_set_state(nid, N_HIGH_MEMORY);
if (N_NORMAL_MEMORY != N_HIGH_MEMORY &&
which I hope is correct. Can you please check it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, Rob Landley <rob@landley.net>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Liu <jiang.liu@huawei.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Yinghai Lu <yinghai@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Lin feng <linfeng@cn.fujitsu.com>
Subject: Re: [PART3 Patch v2 13/14] page_alloc: use N_MEMORY instead N_HIGH_MEMORY change the node_states initialization
Date: Thu, 15 Nov 2012 16:29:20 -0800 [thread overview]
Message-ID: <20121115162920.af46d08a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352969857-26623-14-git-send-email-wency@cn.fujitsu.com>
On Thu, 15 Nov 2012 16:57:36 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:
> N_HIGH_MEMORY stands for the nodes that has normal or high memory.
> N_MEMORY stands for the nodes that has any memory.
>
> The code here need to handle with the nodes which have memory, we should
> use N_MEMORY instead.
>
> Since we introduced N_MEMORY, we update the initialization of node_states.
reset_zone_present_pages() has been removed by the recently-queued
revert-mm-fix-up-zone-present-pages.patch, so I dropped that hunk.
We still have
akpm:/usr/src/25> grep N_HIGH_MEMORY mm/page_alloc.c
[N_HIGH_MEMORY] = { { [0] = 1UL } },
node_set_state(nid, N_HIGH_MEMORY);
if (N_NORMAL_MEMORY != N_HIGH_MEMORY &&
which I hope is correct. Can you please check it?
next prev parent reply other threads:[~2012-11-16 0:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:57 [PART3 Patch v2 00/14] introduce N_MEMORY Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 01/14] node_states: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 02/14] cpuset: use N_MEMORY instead N_HIGH_MEMORY Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 03/14] procfs: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 04/14] memcontrol: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 05/14] oom: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 06/14] mm,migrate: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 07/14] mempolicy: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 08/14] hugetlb: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 09/14] vmstat: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 10/14] kthread: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 11/14] init: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 12/14] vmscan: " Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 13/14] page_alloc: use N_MEMORY instead N_HIGH_MEMORY change the node_states initialization Wen Congyang
2012-11-15 8:57 ` Wen Congyang
2012-11-16 0:29 ` Andrew Morton [this message]
2012-11-16 0:29 ` Andrew Morton
2012-11-16 3:01 ` Wen Congyang
2012-11-16 3:01 ` Wen Congyang
2012-11-15 8:57 ` [PART3 Patch v2 14/14] hotplug: update nodemasks management Wen Congyang
2012-11-15 8:57 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115162920.af46d08a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=rusty@rustcorp.com.au \
--cc=wency@cn.fujitsu.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.