From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Omar Ramirez Luna <omar.luna@linaro.org>
Cc: Jon Hunter <jon-hunter@ti.com>, Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 7/8] ARM: OMAP: Remove unnecessary inclusion of dmtimer.h
Date: Thu, 15 Nov 2012 14:43:23 -0800 [thread overview]
Message-ID: <20121115224323.GD16377@kroah.com> (raw)
In-Reply-To: <CALLhW=5wiTd9u0PorwDH_68K7XRS8_ajDSDOLB7x8F2qvtJvaA@mail.gmail.com>
On Thu, Nov 15, 2012 at 02:42:13PM -0600, Omar Ramirez Luna wrote:
> Hi Jon,
>
> On 14 November 2012 09:53, Jon Hunter <jon-hunter@ti.com> wrote:
> >> diff --git a/drivers/staging/tidspbridge/core/ue_deh.c b/drivers/staging/tidspbridge/core/ue_deh.c
> >> index 3d28b23..6aea6f1 100644
> >> --- a/drivers/staging/tidspbridge/core/ue_deh.c
> >> +++ b/drivers/staging/tidspbridge/core/ue_deh.c
> >> @@ -19,7 +19,6 @@
> >>
> >> #include <linux/kernel.h>
> >> #include <linux/interrupt.h>
> >> -#include <plat/dmtimer.h>
> >>
> >> #include <dspbridge/dbdefs.h>
> >> #include <dspbridge/dspdeh.h>
> >
> > Hi Omar, I should have had you in copy on this one. Are you ok with the
> > removal of the above dmtimer.h include? It does not appear that this
> > file needs to include dmtimer.h.
>
> Indeed, we don't use it here.
>
> > Is it ok for this to go through Tony's tree? If so, care to ACK?
>
> Looks fine to me, but I believe you will want to let Greg know if this
> patch will bypass staging tree.
That's fine with me for such trivial stuff.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] ARM: OMAP: Remove unnecessary inclusion of dmtimer.h
Date: Thu, 15 Nov 2012 14:43:23 -0800 [thread overview]
Message-ID: <20121115224323.GD16377@kroah.com> (raw)
In-Reply-To: <CALLhW=5wiTd9u0PorwDH_68K7XRS8_ajDSDOLB7x8F2qvtJvaA@mail.gmail.com>
On Thu, Nov 15, 2012 at 02:42:13PM -0600, Omar Ramirez Luna wrote:
> Hi Jon,
>
> On 14 November 2012 09:53, Jon Hunter <jon-hunter@ti.com> wrote:
> >> diff --git a/drivers/staging/tidspbridge/core/ue_deh.c b/drivers/staging/tidspbridge/core/ue_deh.c
> >> index 3d28b23..6aea6f1 100644
> >> --- a/drivers/staging/tidspbridge/core/ue_deh.c
> >> +++ b/drivers/staging/tidspbridge/core/ue_deh.c
> >> @@ -19,7 +19,6 @@
> >>
> >> #include <linux/kernel.h>
> >> #include <linux/interrupt.h>
> >> -#include <plat/dmtimer.h>
> >>
> >> #include <dspbridge/dbdefs.h>
> >> #include <dspbridge/dspdeh.h>
> >
> > Hi Omar, I should have had you in copy on this one. Are you ok with the
> > removal of the above dmtimer.h include? It does not appear that this
> > file needs to include dmtimer.h.
>
> Indeed, we don't use it here.
>
> > Is it ok for this to go through Tony's tree? If so, care to ACK?
>
> Looks fine to me, but I believe you will want to let Greg know if this
> patch will bypass staging tree.
That's fine with me for such trivial stuff.
greg k-h
next prev parent reply other threads:[~2012-11-15 22:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 18:13 [PATCH 0/8] ARM: OMAP: Clean-up DMTIMER Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 1/8] ARM: OMAP: Clean-up dmtimer reset code Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 2/8] ARM: OMAP: Define omap_dm_timer_prepare function as static Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 3/8] ARM: OMAP: Don't store timers physical address Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 4/8] ARM: OMAP2+: Remove unnecessary local variable in timer code Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 5/8] ARM: OMAP: Remove unnecessary omap_dm_timer structure declaration Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 6/8] ARM: OMAP: Add platform data header for DMTIMERs Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 18:13 ` [PATCH 7/8] ARM: OMAP: Remove unnecessary inclusion of dmtimer.h Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-14 15:53 ` Jon Hunter
2012-11-14 15:53 ` Jon Hunter
2012-11-15 20:42 ` Omar Ramirez Luna
2012-11-15 20:42 ` Omar Ramirez Luna
2012-11-15 22:43 ` Greg Kroah-Hartman [this message]
2012-11-15 22:43 ` Greg Kroah-Hartman
2012-11-13 18:13 ` [PATCH 8/8] ARM: OMAP: Move plat/dmtimer.h to plat-omap/dmtimer.h Jon Hunter
2012-11-13 18:13 ` Jon Hunter
2012-11-13 22:26 ` Tony Lindgren
2012-11-13 22:26 ` Tony Lindgren
2012-11-13 22:54 ` Jon Hunter
2012-11-13 22:54 ` Jon Hunter
2012-11-13 23:34 ` Tony Lindgren
2012-11-13 23:34 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115224323.GD16377@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=omar.luna@linaro.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.