From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Pavel Emelyanov <xemul@parallels.com>,
James Bottomley <jbottomley@parallels.com>,
Matthew Helsley <matt.helsley@gmail.com>,
aneesh.kumar@linux.vnet.ibm.com, bfields@fieldses.org,
oleg@redhat.com, rientjes@google.com,
tvrtko.ursulin@onelan.co.uk, Andrey Vagin <avagin@openvz.org>
Subject: Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6
Date: Sat, 17 Nov 2012 11:10:39 +0400 [thread overview]
Message-ID: <20121117071039.GA22855@moon> (raw)
In-Reply-To: <20121116155603.2118394c.akpm@linux-foundation.org>
On Fri, Nov 16, 2012 at 03:56:03PM -0800, Andrew Morton wrote:
>
> This is a lousy output format. It's sort-of like a sensible set of
> name-value tuples: "name:value name:value name:value" but
>
> a) it has lots of random pointless whitespace after the colons and
>
> b) several of the labels have spaces in them, just to make life
> harder for parsing code and
>
> c) inotify-wd is secretly printed in decimal while everything else
> is in hex.
>
> What happens if we do something like the below (which will require a
> changelog update)?
Looks good for me, Andrew. The only reason for such whitespace rich format
was to make output column aligned. But it's fine to have name:val as well.
I'll update. Thanks!
Cyrill
next prev parent reply other threads:[~2012-11-17 7:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 15:19 [patch 0/7] Providing additional information in fdinfo sufficient for c/r, v3 Cyrill Gorcunov
2012-11-14 15:19 ` [patch 1/7] procfs: Add ability to plug in auxiliary fdinfo providers Cyrill Gorcunov
2012-11-15 13:47 ` Pavel Emelyanov
2012-11-14 15:19 ` [patch 2/7] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-11-15 13:48 ` Pavel Emelyanov
2012-11-14 15:19 ` [patch 3/7] fs, epoll: Add procfs fdinfo helper v2 Cyrill Gorcunov
2012-11-15 13:49 ` Pavel Emelyanov
2012-11-14 15:19 ` [patch 4/7] fdinfo: Show sigmask for signalfd fd v3 Cyrill Gorcunov
2012-11-15 13:49 ` Pavel Emelyanov
2012-11-14 15:19 ` [patch 5/7] fs, exportfs: Escape nil dereference if no s_export_op present Cyrill Gorcunov
2012-11-15 13:49 ` Pavel Emelyanov
2012-11-14 15:19 ` [patch 6/7] fs, exportfs: Add exportfs_encode_inode_fh helper Cyrill Gorcunov
2012-11-14 17:37 ` J. Bruce Fields
2012-11-15 13:50 ` Pavel Emelyanov
2012-11-14 15:19 ` [patch 7/7] fs, notify: Add procfs fdinfo helper v6 Cyrill Gorcunov
2012-11-15 13:50 ` Pavel Emelyanov
2012-11-16 23:56 ` Andrew Morton
2012-11-17 7:10 ` Cyrill Gorcunov [this message]
2012-11-17 8:34 ` Cyrill Gorcunov
2012-11-20 0:49 ` Andrew Morton
2012-11-20 6:35 ` Cyrill Gorcunov
2012-12-10 2:21 ` Jan Engelhardt
2012-12-10 6:47 ` Cyrill Gorcunov
2012-11-27 0:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121117071039.GA22855@moon \
--to=gorcunov@openvz.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=avagin@openvz.org \
--cc=bfields@fieldses.org \
--cc=jbottomley@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.helsley@gmail.com \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
--cc=tvrtko.ursulin@onelan.co.uk \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.