Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 17 Nov 2012 12:34:37 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> On Sat, Nov 17, 2012 at 11:10:39AM +0400, Cyrill Gorcunov wrote:
> > > 
> > > What happens if we do something like the below (which will require a
> > > changelog update)?
> > 
> > Looks good for me, Andrew. The only reason for such whitespace rich format
> > was to make output column aligned. But it's fine to have name:val as well.
> > I'll update. Thanks!
> 
> Andrew, here is a patch which contains and your change, and changelog update
> and one fix (you've lost %lx for ino number thus compiler warns me about
> missing specificator). Also the inotify/fanotify at first position on the
> line (without dash, as you propose, ie inotify-wd) applies to the whole line,
> that's why I didn't use dashes in first place.

Oh, I see.

>  | pos:	0
>  | flags:	02000000
>  | inotify wd:3 ino:9e7e sdev:800013 mask:800afce ignored_mask:0 fhandle-bytes:8 fhandle-type:1 f_handle:7e9e0000640d1b6d

It's still a bit strange, isn't it?  The "inotify" identifier doesn't
have the colon.  I guess it's unavoidable, as this multiple-name-value
line is being mixed into the same pseudo-file as single name-value lines.

Where *is* this pseudo-file, anyway?  The changelog doesn't tell us
where it lies in the filesystem.

I know!  I'll search the documentation!  /proc/sys/fs/epoll/..., yes?

btw, Documentation/sysctl/fs.txt is missing documentation for
max_user_instances and max_queued_events.  Perhaps you can fix that
when providing the documentation changes for your patch :)