From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] power: Add simple poweroff-gpio driver
Date: Sat, 17 Nov 2012 09:34:34 +0100 [thread overview]
Message-ID: <20121117083434.GI24569@lunn.ch> (raw)
In-Reply-To: <20121116192525.GA25838@schnuecks.de>
> > + * Hold configuration here, cannot be more than one instance of the driver
> > + * since pm_power_off itself is global.
> > + */
> > +static int gpio_num = -1;
> > +static int gpio_active_low;
> > +
> > +static void gpio_poweroff_do_poweroff(void)
> > +{
> > + BUG_ON(gpio_num == -1);
> > +
> > + /* drive it active */
> > + gpio_direction_output(gpio_num, !gpio_active_low);
> > + mdelay(100);
> > + /* rising edge or drive inactive */
> > + gpio_set_value(gpio_num, gpio_active_low);
> > + mdelay(100);
> > + /* falling edge */
> > + gpio_set_value(gpio_num, !gpio_active_low);
> > +
> > + /* give it some time */
> > + mdelay(100);
>
> On the IB-NAS 6210 I need to increase this delay to a whopping 3000
> milliseconds to suppress the warning (2000 is not enough). Is it
> acceptable to increase this to such a high value or do we need
> another solution?
Hi Simon
It is interesting how slow these things are at turning off. I already
had to increase it once from 10ms for the DNSKW.
So i will increase it to 3000 in the next spin of the patches.
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Simon Baatz <gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org,
linux ARM
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2 1/3] power: Add simple poweroff-gpio driver
Date: Sat, 17 Nov 2012 09:34:34 +0100 [thread overview]
Message-ID: <20121117083434.GI24569@lunn.ch> (raw)
In-Reply-To: <20121116192525.GA25838-2BA9cf72eNkOIzVOb1FTxg@public.gmane.org>
> > + * Hold configuration here, cannot be more than one instance of the driver
> > + * since pm_power_off itself is global.
> > + */
> > +static int gpio_num = -1;
> > +static int gpio_active_low;
> > +
> > +static void gpio_poweroff_do_poweroff(void)
> > +{
> > + BUG_ON(gpio_num == -1);
> > +
> > + /* drive it active */
> > + gpio_direction_output(gpio_num, !gpio_active_low);
> > + mdelay(100);
> > + /* rising edge or drive inactive */
> > + gpio_set_value(gpio_num, gpio_active_low);
> > + mdelay(100);
> > + /* falling edge */
> > + gpio_set_value(gpio_num, !gpio_active_low);
> > +
> > + /* give it some time */
> > + mdelay(100);
>
> On the IB-NAS 6210 I need to increase this delay to a whopping 3000
> milliseconds to suppress the warning (2000 is not enough). Is it
> acceptable to increase this to such a high value or do we need
> another solution?
Hi Simon
It is interesting how slow these things are at turning off. I already
had to increase it once from 10ms for the DNSKW.
So i will increase it to 3000 in the next spin of the patches.
Thanks
Andrew
next prev parent reply other threads:[~2012-11-17 8:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 15:44 [PATCH v2 0/3] GPIO driver to turn power off Andrew Lunn
2012-11-13 15:44 ` Andrew Lunn
2012-11-13 15:44 ` [PATCH v2 1/3] power: Add simple poweroff-gpio driver Andrew Lunn
2012-11-13 15:44 ` Andrew Lunn
2012-11-15 11:08 ` Linus Walleij
2012-11-15 11:08 ` Linus Walleij
2012-11-16 19:25 ` Simon Baatz
2012-11-16 19:25 ` Simon Baatz
2012-11-17 8:34 ` Andrew Lunn [this message]
2012-11-17 8:34 ` Andrew Lunn
2012-11-13 15:44 ` [PATCH v2 2/3] ARM: Kirkwood: Convert DNSKW to use gpio-poweroff Andrew Lunn
2012-11-13 15:44 ` Andrew Lunn
2012-11-13 15:44 ` [PATCH v2 3/3] ARM: Kirkwood: Convert IB62x0 " Andrew Lunn
2012-11-13 15:44 ` Andrew Lunn
2012-11-16 19:32 ` Simon Baatz
2012-11-16 19:32 ` Simon Baatz
2012-11-17 8:30 ` Andrew Lunn
2012-11-17 8:30 ` Andrew Lunn
2012-11-16 14:19 ` [PATCH v2 0/3] GPIO driver to turn power off Jason Cooper
2012-11-16 14:19 ` Jason Cooper
2012-11-16 19:23 ` Anton Vorontsov
2012-11-16 19:23 ` Anton Vorontsov
2012-11-17 8:29 ` Andrew Lunn
2012-11-17 8:29 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121117083434.GI24569@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.