* [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation
@ 2012-11-19 1:38 Jingoo Han
2012-11-19 22:21 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2012-11-19 1:38 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'Joe Perches',
'Jingoo Han'
This patch removes remove an unnecessary line continuation in
pm860x_backlight_probe(). Also, a checkpatch warning is fixed
as below:
WARNING: Avoid unnecessary line continuations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Joe Perches <joe@perches.com>
---
drivers/video/backlight/88pm860x_bl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c
index bb21412..6e1bbf8 100644
--- a/drivers/video/backlight/88pm860x_bl.c
+++ b/drivers/video/backlight/88pm860x_bl.c
@@ -228,7 +228,7 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
sprintf(name, "backlight-%d", pdev->id);
data->port = pdev->id;
data->chip = chip;
- data->i2c = (chip->id == CHIP_PM8606) ? chip->client \
+ data->i2c = (chip->id == CHIP_PM8606) ? chip->client
: chip->companion;
data->current_brightness = MAX_BRIGHTNESS;
if (pm860x_backlight_dt_init(pdev, data, name)) {
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation
2012-11-19 1:38 [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation Jingoo Han
@ 2012-11-19 22:21 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2012-11-19 22:21 UTC (permalink / raw)
To: Jingoo Han
Cc: 'LKML', 'Richard Purdie', 'Joe Perches'
On Mon, 19 Nov 2012 10:38:53 +0900
Jingoo Han <jg1.han@samsung.com> wrote:
> This patch removes remove an unnecessary line continuation in
> pm860x_backlight_probe(). Also, a checkpatch warning is fixed
> as below:
>
> WARNING: Avoid unnecessary line continuations
>
> --- a/drivers/video/backlight/88pm860x_bl.c
> +++ b/drivers/video/backlight/88pm860x_bl.c
> @@ -228,7 +228,7 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
> sprintf(name, "backlight-%d", pdev->id);
> data->port = pdev->id;
> data->chip = chip;
> - data->i2c = (chip->id == CHIP_PM8606) ? chip->client \
> + data->i2c = (chip->id == CHIP_PM8606) ? chip->client
> : chip->companion;
> data->current_brightness = MAX_BRIGHTNESS;
> if (pm860x_backlight_dt_init(pdev, data, name)) {
It's still pretty ugly, but looky here:
diff -puN drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix drivers/video/backlight/88pm860x_bl.c
--- a/drivers/video/backlight/88pm860x_bl.c~backlight-88pm860x_bl-remove-an-unnecessary-line-continuation-fix
+++ a/drivers/video/backlight/88pm860x_bl.c
@@ -228,8 +228,7 @@ static int pm860x_backlight_probe(struct
sprintf(name, "backlight-%d", pdev->id);
data->port = pdev->id;
data->chip = chip;
- data->i2c = (chip->id == CHIP_PM8606) ? chip->client
- : chip->companion;
+ data->i2c = (chip->id == CHIP_PM8606) ? chip->client : chip->companion;
data->current_brightness = MAX_BRIGHTNESS;
if (pm860x_backlight_dt_init(pdev, data, name)) {
if (pdata) {
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-19 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 1:38 [PATCH] backlight: 88pm860x_bl: remove an unnecessary line continuation Jingoo Han
2012-11-19 22:21 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.