All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 10/14] KVM: ARM: User space API for getting/setting co-proc registers
Date: Mon, 19 Nov 2012 15:02:44 +0000	[thread overview]
Message-ID: <20121119150244.GC3205@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20121110154321.2836.75612.stgit@chazy-air>

On Sat, Nov 10, 2012 at 03:43:21PM +0000, Christoffer Dall wrote:
> The following three ioctls are implemented:
>  -  KVM_GET_REG_LIST
>  -  KVM_GET_ONE_REG
>  -  KVM_SET_ONE_REG

[...]

> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 845ceda..9671cd2 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1798,6 +1798,11 @@ is the register group type, or coprocessor number:
>  ARM core registers have the following id bit patterns:
>    0x4002 0000 0010 <index into the kvm_regs struct:16>
> 
> +ARM 32-bit CP15 registers have the following id bit patterns:
> +  0x4002 0000 000F <zero:1> <crn:4> <crm:4> <opc1:4> <opc2:3>
> +
> +ARM 64-bit CP15 registers have the following id bit patterns:
> +  0x4003 0000 000F <zero:1> <zero:4> <crm:4> <opc1:4> <zero:3>
> 
> 
>  4.69 KVM_GET_ONE_REG
> @@ -2139,6 +2144,45 @@ This ioctl returns the guest registers that are supported for the
>  KVM_GET_ONE_REG/KVM_SET_ONE_REG calls.
> 
> 
> +4.77 KVM_ARM_VCPU_INIT
> +
> +Capability: basic
> +Architectures: arm
> +Type: vcpu ioctl
> +Parameters: struct struct kvm_vcpu_init (in)
> +Returns: 0 on success; -1 on error
> +Errors:
> +  EINVAL:    the target is unknown, or the combination of features is invalid.
> +  ENOENT:    a features bit specified is unknown.
> +
> +This tells KVM what type of CPU to present to the guest, and what
> +optional features it should have.  This will cause a reset of the cpu
> +registers to their initial values.  If this is not called, KVM_RUN will
> +return ENOEXEC for that vcpu.
> +
> +Note that because some registers reflect machine topology, all vcpus
> +should be created before this ioctl is invoked.
> +
> +4.78 KVM_GET_REG_LIST
> +
> +Capability: basic
> +Architectures: arm
> +Type: vcpu ioctl
> +Parameters: struct kvm_reg_list (in/out)
> +Returns: 0 on success; -1 on error
> +Errors:
> +  E2BIG:     the reg index list is too big to fit in the array specified by
> +             the user (the number required will be written into n).
> +
> +struct kvm_reg_list {
> +       __u64 n; /* number of registers in reg[] */
> +       __u64 reg[0];
> +};
> +
> +This ioctl returns the guest registers that are supported for the
> +KVM_GET_ONE_REG/KVM_SET_ONE_REG calls.
> +
> +

You already added this hunk earlier (and looking at the final result,
you do end up wih two entries for 4.77 and 4.78).

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Rusty Russell <rusty.russell@linaro.org>
Subject: Re: [PATCH v4 10/14] KVM: ARM: User space API for getting/setting co-proc registers
Date: Mon, 19 Nov 2012 15:02:44 +0000	[thread overview]
Message-ID: <20121119150244.GC3205@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20121110154321.2836.75612.stgit@chazy-air>

On Sat, Nov 10, 2012 at 03:43:21PM +0000, Christoffer Dall wrote:
> The following three ioctls are implemented:
>  -  KVM_GET_REG_LIST
>  -  KVM_GET_ONE_REG
>  -  KVM_SET_ONE_REG

[...]

> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 845ceda..9671cd2 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1798,6 +1798,11 @@ is the register group type, or coprocessor number:
>  ARM core registers have the following id bit patterns:
>    0x4002 0000 0010 <index into the kvm_regs struct:16>
> 
> +ARM 32-bit CP15 registers have the following id bit patterns:
> +  0x4002 0000 000F <zero:1> <crn:4> <crm:4> <opc1:4> <opc2:3>
> +
> +ARM 64-bit CP15 registers have the following id bit patterns:
> +  0x4003 0000 000F <zero:1> <zero:4> <crm:4> <opc1:4> <zero:3>
> 
> 
>  4.69 KVM_GET_ONE_REG
> @@ -2139,6 +2144,45 @@ This ioctl returns the guest registers that are supported for the
>  KVM_GET_ONE_REG/KVM_SET_ONE_REG calls.
> 
> 
> +4.77 KVM_ARM_VCPU_INIT
> +
> +Capability: basic
> +Architectures: arm
> +Type: vcpu ioctl
> +Parameters: struct struct kvm_vcpu_init (in)
> +Returns: 0 on success; -1 on error
> +Errors:
> +  EINVAL:    the target is unknown, or the combination of features is invalid.
> +  ENOENT:    a features bit specified is unknown.
> +
> +This tells KVM what type of CPU to present to the guest, and what
> +optional features it should have.  This will cause a reset of the cpu
> +registers to their initial values.  If this is not called, KVM_RUN will
> +return ENOEXEC for that vcpu.
> +
> +Note that because some registers reflect machine topology, all vcpus
> +should be created before this ioctl is invoked.
> +
> +4.78 KVM_GET_REG_LIST
> +
> +Capability: basic
> +Architectures: arm
> +Type: vcpu ioctl
> +Parameters: struct kvm_reg_list (in/out)
> +Returns: 0 on success; -1 on error
> +Errors:
> +  E2BIG:     the reg index list is too big to fit in the array specified by
> +             the user (the number required will be written into n).
> +
> +struct kvm_reg_list {
> +       __u64 n; /* number of registers in reg[] */
> +       __u64 reg[0];
> +};
> +
> +This ioctl returns the guest registers that are supported for the
> +KVM_GET_ONE_REG/KVM_SET_ONE_REG calls.
> +
> +

You already added this hunk earlier (and looking at the final result,
you do end up wih two entries for 4.77 and 4.78).

Will

  reply	other threads:[~2012-11-19 15:02 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-10 15:42 [PATCH v4 00/14] KVM/ARM Implementation Christoffer Dall
2012-11-10 15:42 ` Christoffer Dall
2012-11-10 15:42 ` [PATCH v4 01/14] ARM: Add page table and page defines needed by KVM Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:14   ` Will Deacon
2012-11-19 14:14     ` Will Deacon
2012-11-29 15:57     ` Christoffer Dall
2012-11-29 15:57       ` Christoffer Dall
2012-11-30 11:46       ` Will Deacon
2012-11-30 11:46         ` Will Deacon
2012-11-30 15:54         ` Christoffer Dall
2012-11-30 15:54           ` Christoffer Dall
2012-11-10 15:42 ` [PATCH v4 02/14] ARM: Section based HYP idmap Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:16   ` Will Deacon
2012-11-19 14:16     ` Will Deacon
2012-11-29 18:59     ` Christoffer Dall
2012-11-29 18:59       ` Christoffer Dall
2012-11-30 10:58       ` Will Deacon
2012-11-30 10:58         ` Will Deacon
2012-11-30 16:29         ` Christoffer Dall
2012-11-30 16:29           ` Christoffer Dall
2012-11-19 14:25   ` Rob Herring
2012-11-19 14:25     ` Rob Herring
2012-11-10 15:42 ` [PATCH v4 03/14] ARM: Factor out cpuid implementor and part number Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:21   ` Will Deacon
2012-11-19 14:21     ` Will Deacon
2012-11-29 21:38     ` Christoffer Dall
2012-11-29 21:38       ` Christoffer Dall
2012-11-30 10:21       ` Will Deacon
2012-11-30 10:21         ` Will Deacon
2012-11-30 15:42         ` Christoffer Dall
2012-11-30 15:42           ` Christoffer Dall
2012-11-10 15:42 ` [PATCH v4 04/14] KVM: ARM: Initial skeleton to compile KVM support Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:41   ` Will Deacon
2012-11-19 14:41     ` Will Deacon
2012-11-29 22:36     ` Christoffer Dall
2012-11-29 22:36       ` Christoffer Dall
2012-11-10 15:42 ` [PATCH v4 05/14] KVM: ARM: Hypervisor inititalization Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:51   ` Will Deacon
2012-11-19 14:51     ` Will Deacon
2012-11-19 15:27     ` Cyril Chemparathy
2012-11-19 15:27       ` Cyril Chemparathy
2012-11-30  5:41     ` Christoffer Dall
2012-11-30  5:41       ` Christoffer Dall
2012-11-10 15:42 ` [PATCH v4 06/14] KVM: ARM: Memory virtualization setup Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:53   ` Will Deacon
2012-11-19 14:53     ` Will Deacon
2012-11-19 15:05     ` Christoffer Dall
2012-11-19 15:05       ` Christoffer Dall
2012-11-10 15:42 ` [PATCH v4 07/14] KVM: ARM: Inject IRQs and FIQs from userspace Christoffer Dall
2012-11-10 15:42   ` Christoffer Dall
2012-11-19 14:55   ` Will Deacon
2012-11-19 14:55     ` Will Deacon
2012-11-19 15:04     ` Christoffer Dall
2012-11-19 15:04       ` Christoffer Dall
2012-11-19 15:26       ` Will Deacon
2012-11-19 15:26         ` Will Deacon
2012-11-19 16:09         ` Christoffer Dall
2012-11-19 16:09           ` Christoffer Dall
2012-11-19 16:21           ` Will Deacon
2012-11-19 16:21             ` Will Deacon
2012-11-30  6:13             ` Christoffer Dall
2012-11-30  6:13               ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 08/14] KVM: ARM: World-switch implementation Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-19 14:57   ` Will Deacon
2012-11-19 14:57     ` Will Deacon
2012-11-30  6:37     ` Christoffer Dall
2012-11-30  6:37       ` Christoffer Dall
2012-11-30 15:15       ` Will Deacon
2012-11-30 15:15         ` Will Deacon
2012-11-30 16:47         ` Christoffer Dall
2012-11-30 16:47           ` Christoffer Dall
2012-11-30 17:14           ` Will Deacon
2012-11-30 17:14             ` Will Deacon
2012-11-30 18:49             ` Christoffer Dall
2012-11-30 18:49               ` Christoffer Dall
2012-12-03 10:33               ` Marc Zyngier
2012-12-03 10:33                 ` Marc Zyngier
2012-12-03 15:05                 ` Christoffer Dall
2012-12-03 15:05                   ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 09/14] KVM: ARM: Emulation framework and CP15 emulation Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-19 15:01   ` Will Deacon
2012-11-19 15:01     ` Will Deacon
2012-11-19 15:27     ` [kvmarm] " Peter Maydell
2012-11-19 15:27       ` Peter Maydell
2012-11-20  2:18       ` Rusty Russell
2012-11-20  2:18         ` Rusty Russell
2012-11-30 20:22     ` Christoffer Dall
2012-11-30 20:22       ` Christoffer Dall
2012-12-03 11:05       ` Will Deacon
2012-12-03 11:05         ` Will Deacon
2012-12-03 19:09         ` Christoffer Dall
2012-12-03 19:09           ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 10/14] KVM: ARM: User space API for getting/setting co-proc registers Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-19 15:02   ` Will Deacon [this message]
2012-11-19 15:02     ` Will Deacon
2012-11-30  6:42     ` Christoffer Dall
2012-11-30  6:42       ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 11/14] KVM: ARM: Demux CCSIDR in the userspace API Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-19 15:03   ` Will Deacon
2012-11-19 15:03     ` Will Deacon
2012-11-30  6:45     ` Christoffer Dall
2012-11-30  6:45       ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 12/14] KVM: ARM: VFP userspace interface Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 13/14] KVM: ARM: Handle guest faults in KVM Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-19 15:07   ` Will Deacon
2012-11-19 15:07     ` Will Deacon
2012-11-30 21:40     ` Christoffer Dall
2012-11-30 21:40       ` Christoffer Dall
2012-12-03 13:06       ` Will Deacon
2012-12-03 13:06         ` Will Deacon
2012-12-03 15:02         ` Christoffer Dall
2012-12-03 15:02           ` Christoffer Dall
2012-11-10 15:43 ` [PATCH v4 14/14] KVM: ARM: Handle I/O aborts Christoffer Dall
2012-11-10 15:43   ` Christoffer Dall
2012-11-19 15:09   ` Will Deacon
2012-11-19 15:09     ` Will Deacon
2012-11-30 14:46     ` Dave Martin
2012-11-30 14:46       ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119150244.GC3205@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.