* [PATCH] perf tools: fix dso__fprintf() print statement
@ 2012-11-20 9:51 Stephane Eranian
2013-01-24 18:35 ` [tip:perf/core] perf symbols: Fix " tip-bot for Stephane Eranian
0 siblings, 1 reply; 2+ messages in thread
From: Stephane Eranian @ 2012-11-20 9:51 UTC (permalink / raw)
To: linux-kernel; +Cc: acme, peterz, mingo, namhyung.kim
Was ignoring the dso type (function vs. variable) and
was therefore printing bogus information.
Signed-off-by: Stephane Eranian <eranian@google.com>
---
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index d6d9a46..be43785 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -583,7 +583,7 @@ size_t dso__fprintf(struct dso *dso, enum map_type type, FILE *fp)
if (dso->short_name != dso->long_name)
ret += fprintf(fp, "%s, ", dso->long_name);
ret += fprintf(fp, "%s, %sloaded, ", map_type__name[type],
- dso->loaded ? "" : "NOT ");
+ dso__loaded(dso, type) ? "" : "NOT ");
ret += dso__fprintf_buildid(dso, fp);
ret += fprintf(fp, ")\n");
for (nd = rb_first(&dso->symbols[type]); nd; nd = rb_next(nd)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/core] perf symbols: Fix dso__fprintf() print statement
2012-11-20 9:51 [PATCH] perf tools: fix dso__fprintf() print statement Stephane Eranian
@ 2013-01-24 18:35 ` tip-bot for Stephane Eranian
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Stephane Eranian @ 2013-01-24 18:35 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, eranian, hpa, mingo, peterz, namhyung.kim,
tglx, mingo
Commit-ID: 919d590f13c94c5465db723178e4b72200fd5f90
Gitweb: http://git.kernel.org/tip/919d590f13c94c5465db723178e4b72200fd5f90
Author: Stephane Eranian <eranian@google.com>
AuthorDate: Tue, 20 Nov 2012 10:51:02 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Sun, 9 Dec 2012 08:46:04 -0300
perf symbols: Fix dso__fprintf() print statement
Was ignoring the dso type (function vs. variable) and was therefore
printing bogus information.
Signed-off-by: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20121120095101.GA5939@quad
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/dso.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index d6d9a46..be43785 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -583,7 +583,7 @@ size_t dso__fprintf(struct dso *dso, enum map_type type, FILE *fp)
if (dso->short_name != dso->long_name)
ret += fprintf(fp, "%s, ", dso->long_name);
ret += fprintf(fp, "%s, %sloaded, ", map_type__name[type],
- dso->loaded ? "" : "NOT ");
+ dso__loaded(dso, type) ? "" : "NOT ");
ret += dso__fprintf_buildid(dso, fp);
ret += fprintf(fp, ")\n");
for (nd = rb_first(&dso->symbols[type]); nd; nd = rb_next(nd)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-24 18:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 9:51 [PATCH] perf tools: fix dso__fprintf() print statement Stephane Eranian
2013-01-24 18:35 ` [tip:perf/core] perf symbols: Fix " tip-bot for Stephane Eranian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.