All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files
Date: Tue, 20 Nov 2012 16:08:46 +0000	[thread overview]
Message-ID: <20121120160846.GC28265@gmail.com> (raw)
In-Reply-To: <1352985288-29518-2-git-send-email-lee.jones@linaro.org>

On Thu, 15 Nov 2012, Lee Jones wrote:

> GPIO numbers for the newly created gpio-regulator will differ from
> board to board. Therefore it's not sensible to leave this information
> in the top level DTSI file. Let's move them out to the DTS files
> where they can correctly vary.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/dbx5x0.dtsi    |    2 --
>  arch/arm/boot/dts/hrefprev60.dts |    7 +++++++
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> index d8ba489..9f55363 100644
> --- a/arch/arm/boot/dts/dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> @@ -638,8 +638,6 @@
>  			regulator-name = "mmci-reg";
>  			regulator-type = "voltage";
>  
> -			gpios = <&tc3589x_gpio 18 0x4>;
> -			gpio-enable = <&tc3589x_gpio 17 0x4>;
>  			states = <1800000 0x1
>  				  2900000 0x0>;
>  
> diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts
> index b398946..eec29c4 100644
> --- a/arch/arm/boot/dts/hrefprev60.dts
> +++ b/arch/arm/boot/dts/hrefprev60.dts
> @@ -37,5 +37,12 @@
>  				reset-gpio = <&tc3589x_gpio 13 0x4>;
>  			};
>  		};
> +
> +		vmmci: regulator-gpio {
> +			gpios = <&tc3589x_gpio 18 0x4>;
> +			gpio-enable = <&tc3589x_gpio 17 0x4>;
> +
> +			status = "okay";
> +		};
>  	};
>  };
> -- 
> 1.7.9.5

Prod for Linus.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, linus.walleij@stericsson.com
Subject: Re: [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files
Date: Tue, 20 Nov 2012 16:08:46 +0000	[thread overview]
Message-ID: <20121120160846.GC28265@gmail.com> (raw)
In-Reply-To: <1352985288-29518-2-git-send-email-lee.jones@linaro.org>

On Thu, 15 Nov 2012, Lee Jones wrote:

> GPIO numbers for the newly created gpio-regulator will differ from
> board to board. Therefore it's not sensible to leave this information
> in the top level DTSI file. Let's move them out to the DTS files
> where they can correctly vary.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/dbx5x0.dtsi    |    2 --
>  arch/arm/boot/dts/hrefprev60.dts |    7 +++++++
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> index d8ba489..9f55363 100644
> --- a/arch/arm/boot/dts/dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> @@ -638,8 +638,6 @@
>  			regulator-name = "mmci-reg";
>  			regulator-type = "voltage";
>  
> -			gpios = <&tc3589x_gpio 18 0x4>;
> -			gpio-enable = <&tc3589x_gpio 17 0x4>;
>  			states = <1800000 0x1
>  				  2900000 0x0>;
>  
> diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts
> index b398946..eec29c4 100644
> --- a/arch/arm/boot/dts/hrefprev60.dts
> +++ b/arch/arm/boot/dts/hrefprev60.dts
> @@ -37,5 +37,12 @@
>  				reset-gpio = <&tc3589x_gpio 13 0x4>;
>  			};
>  		};
> +
> +		vmmci: regulator-gpio {
> +			gpios = <&tc3589x_gpio 18 0x4>;
> +			gpio-enable = <&tc3589x_gpio 17 0x4>;
> +
> +			status = "okay";
> +		};
>  	};
>  };
> -- 
> 1.7.9.5

Prod for Linus.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2012-11-20 16:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 13:14 [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-15 13:14 ` Lee Jones
2012-11-15 13:14 ` [PATCH 2/2] ARM: ux500: Move board specific GPIO info out to subordinate DTS files Lee Jones
2012-11-15 13:14   ` Lee Jones
2012-11-20 16:08   ` Lee Jones [this message]
2012-11-20 16:08     ` Lee Jones
2012-11-20 22:38   ` Linus Walleij
2012-11-20 22:38     ` Linus Walleij
2012-11-20 16:08 ` [PATCH 1/2] ARM: ux500: Disable the MMCI gpio-regulator by default Lee Jones
2012-11-20 16:08   ` Lee Jones
2012-11-20 22:37 ` Linus Walleij
2012-11-20 22:37   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121120160846.GC28265@gmail.com \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.