All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 1/3] OF: Add helper for matching against linux,stdout-path
Date: Tue, 20 Nov 2012 16:51:56 +0000	[thread overview]
Message-ID: <20121120165156.395713E102F@localhost> (raw)
In-Reply-To: <20121119095202.GL4398@game.jcrosoft.org>

On Mon, 19 Nov 2012 10:52:02 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> On 10:31 Thu 15 Nov     , Sascha Hauer wrote:
> > devicetrees may have a linux,stdout-path property in the chosen
> > node describing the console device. This adds a helper function
> > to match a device against this property so a driver can call
> > add_preferred_console for a matching device.
> 
> I like it but I've an issue with it I cannot specify the option for
> 
> as example I need to set the uart at 38400n8 or 115200n8 regarless of wath the
> booloader did

Right. stdout-path can have a set of arguments appended for things like
serial speed.  ePAPR says this about stdout-path:

A string that specifies the full path to the node representing the
device to be used for boot console output. If the character ":" is
present in the value it terminates the path. The value may be an alias.

If the stdin-path property is not specified, stdout-path should be
assumed to define the input device.

So, this function needs to do three more things:
- also look for 'stdout-path' (in addition to 'linux,stdout-path')
- Parse for a ':' in the path and trim that off so it can be used for
  arguments. (Bonus: return the arguments to the caller)
- make sure that it can handle the path containing an alias (I've just
  not checked if the current code will handle this)

g.

WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] OF: Add helper for matching against linux, stdout-path
Date: Tue, 20 Nov 2012 16:51:56 +0000	[thread overview]
Message-ID: <20121120165156.395713E102F@localhost> (raw)
In-Reply-To: <20121119095202.GL4398@game.jcrosoft.org>

On Mon, 19 Nov 2012 10:52:02 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> On 10:31 Thu 15 Nov     , Sascha Hauer wrote:
> > devicetrees may have a linux,stdout-path property in the chosen
> > node describing the console device. This adds a helper function
> > to match a device against this property so a driver can call
> > add_preferred_console for a matching device.
> 
> I like it but I've an issue with it I cannot specify the option for
> 
> as example I need to set the uart at 38400n8 or 115200n8 regarless of wath the
> booloader did

Right. stdout-path can have a set of arguments appended for things like
serial speed.  ePAPR says this about stdout-path:

A string that specifies the full path to the node representing the
device to be used for boot console output. If the character ":" is
present in the value it terminates the path. The value may be an alias.

If the stdin-path property is not specified, stdout-path should be
assumed to define the input device.

So, this function needs to do three more things:
- also look for 'stdout-path' (in addition to 'linux,stdout-path')
- Parse for a ':' in the path and trim that off so it can be used for
  arguments. (Bonus: return the arguments to the caller)
- make sure that it can handle the path containing an alias (I've just
  not checked if the current code will handle this)

g.

  reply	other threads:[~2012-11-20 16:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15  9:31 [PATCH v4] linux,stdout-path helper Sascha Hauer
2012-11-15  9:31 ` Sascha Hauer
2012-11-15  9:31 ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Sascha Hauer
2012-11-15  9:31   ` Sascha Hauer
2012-11-19  9:52   ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-19  9:52     ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-20 16:51     ` Grant Likely [this message]
2012-11-20 16:51       ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Grant Likely
     [not found] ` <1352971866-540-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15  9:31   ` [PATCH 2/3] serial: i.MX: Make console support non optional Sascha Hauer
2012-11-15  9:31     ` Sascha Hauer
2012-11-15  9:31     ` Sascha Hauer
2012-11-15  9:31 ` [PATCH 3/3] serial: i.MX: evaluate linux,stdout-path property Sascha Hauer
2012-11-15  9:31   ` Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2012-11-02  9:48 [PATCH v3] linux,stdout-path helper Sascha Hauer
2012-11-02  9:48 ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Sascha Hauer
2012-11-02  9:48   ` Sascha Hauer
2012-11-14 20:43   ` Greg Kroah-Hartman
2012-11-14 20:43     ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Greg Kroah-Hartman
2012-11-14 20:49   ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Grant Likely
2012-11-14 20:49     ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Grant Likely
2012-11-15  8:04     ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Sascha Hauer
2012-11-15  8:04       ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Sascha Hauer
2012-11-15  8:49     ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Sascha Hauer
2012-11-15  8:49       ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Sascha Hauer
2012-11-15  9:10       ` [PATCH 1/3] OF: Add helper for matching against linux,stdout-path Grant Likely
2012-11-15  9:10         ` [PATCH 1/3] OF: Add helper for matching against linux, stdout-path Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121120165156.395713E102F@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=alan@linux.intel.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.