All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Mark A. Greer" <mgreer@animalcreek.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, dmitry.kasatkin@intel.com,
	rmk+kernel@arm.linux.org.uk, paul@pwsan.com,
	khilman@deeprootsystems.com
Subject: Re: [PATCH v4 5/8] crypto: omap-sham: Remove cpu_is/omap_type check from driver
Date: Tue, 20 Nov 2012 17:02:58 -0800	[thread overview]
Message-ID: <20121121010257.GR18567@atomide.com> (raw)
In-Reply-To: <1353351301-6453-6-git-send-email-mgreer@animalcreek.com>

* Mark A. Greer <mgreer@animalcreek.com> [121119 10:58]:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> The omap-sham driver should not check the CPU class or the
> type of OMAP device its on.  The platform code should do
> that instead.

I think I already have a similar patch queued in linux next.

Regards,

Tony
 
> CC: Paul Walmsley <paul@pwsan.com>
> CC: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
>  drivers/crypto/omap-sham.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
> index a3fd6fc..f50387c 100644
> --- a/drivers/crypto/omap-sham.c
> +++ b/drivers/crypto/omap-sham.c
> @@ -37,7 +37,6 @@
>  #include <crypto/hash.h>
>  #include <crypto/internal/hash.h>
>  
> -#include <plat/cpu.h>
>  #include <plat/dma.h>
>  #include <mach/irqs.h>
>  
> @@ -1289,13 +1288,6 @@ static int __init omap_sham_mod_init(void)
>  {
>  	pr_info("loading %s driver\n", "omap-sham");
>  
> -	if (!cpu_class_is_omap2() ||
> -		(omap_type() != OMAP2_DEVICE_TYPE_SEC &&
> -			omap_type() != OMAP2_DEVICE_TYPE_EMU)) {
> -		pr_err("Unsupported cpu\n");
> -		return -ENODEV;
> -	}
> -
>  	return platform_driver_register(&omap_sham_driver);
>  }
>  
> -- 
> 1.7.12
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] crypto: omap-sham: Remove cpu_is/omap_type check from driver
Date: Tue, 20 Nov 2012 17:02:58 -0800	[thread overview]
Message-ID: <20121121010257.GR18567@atomide.com> (raw)
In-Reply-To: <1353351301-6453-6-git-send-email-mgreer@animalcreek.com>

* Mark A. Greer <mgreer@animalcreek.com> [121119 10:58]:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> The omap-sham driver should not check the CPU class or the
> type of OMAP device its on.  The platform code should do
> that instead.

I think I already have a similar patch queued in linux next.

Regards,

Tony
 
> CC: Paul Walmsley <paul@pwsan.com>
> CC: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
>  drivers/crypto/omap-sham.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
> index a3fd6fc..f50387c 100644
> --- a/drivers/crypto/omap-sham.c
> +++ b/drivers/crypto/omap-sham.c
> @@ -37,7 +37,6 @@
>  #include <crypto/hash.h>
>  #include <crypto/internal/hash.h>
>  
> -#include <plat/cpu.h>
>  #include <plat/dma.h>
>  #include <mach/irqs.h>
>  
> @@ -1289,13 +1288,6 @@ static int __init omap_sham_mod_init(void)
>  {
>  	pr_info("loading %s driver\n", "omap-sham");
>  
> -	if (!cpu_class_is_omap2() ||
> -		(omap_type() != OMAP2_DEVICE_TYPE_SEC &&
> -			omap_type() != OMAP2_DEVICE_TYPE_EMU)) {
> -		pr_err("Unsupported cpu\n");
> -		return -ENODEV;
> -	}
> -
>  	return platform_driver_register(&omap_sham_driver);
>  }
>  
> -- 
> 1.7.12
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-11-21  1:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 18:54 [PATCH v4 0/8] crypto: omap-sham updates Mark A. Greer
2012-11-19 18:54 ` Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 1/8] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-11-19 18:54   ` Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 2/8] ARM: OMAP2xxx: hwmod: Add DMA support for SHAM module Mark A. Greer
2012-11-19 18:54   ` Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 3/8] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-11-19 18:54   ` Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 4/8] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present Mark A. Greer
2012-11-19 18:54   ` Mark A. Greer
2012-11-19 18:54 ` [PATCH v4 5/8] crypto: omap-sham: Remove cpu_is/omap_type check from driver Mark A. Greer
2012-11-19 18:54   ` Mark A. Greer
2012-11-21  1:02   ` Tony Lindgren [this message]
2012-11-21  1:02     ` Tony Lindgren
2012-11-19 18:54 ` [PATCH v4 6/8] crypto: omap-sham: Convert to use pm_runtime API Mark A. Greer
2012-11-19 18:54   ` Mark A. Greer
2012-11-19 18:55 ` [PATCH v4 7/8] crypto: omap-sham: Add code to use dmaengine API Mark A. Greer
2012-11-19 18:55   ` Mark A. Greer
2012-11-21  1:10   ` Tony Lindgren
2012-11-21  1:10     ` Tony Lindgren
2012-11-19 18:55 ` [PATCH v4 8/8] crypto: omap_sham: Remove usage of private DMA API Mark A. Greer
2012-11-19 18:55   ` Mark A. Greer
2012-12-05 10:28 ` [PATCH v4 0/8] crypto: omap-sham updates Kasatkin, Dmitry
2012-12-05 10:28   ` Kasatkin, Dmitry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121010257.GR18567@atomide.com \
    --to=tony@atomide.com \
    --cc=davem@davemloft.net \
    --cc=dmitry.kasatkin@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=paul@pwsan.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.