From: Tony Lindgren <tony@atomide.com>
To: "Mark A. Greer" <mgreer@animalcreek.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, dmitry.kasatkin@intel.com,
rmk+kernel@arm.linux.org.uk, paul@pwsan.com,
khilman@deeprootsystems.com
Subject: Re: [PATCH 4/7] crypto: omap-aes: Remove cpu_is/omap_type check from driver
Date: Tue, 20 Nov 2012 17:03:43 -0800 [thread overview]
Message-ID: <20121121010343.GS18567@atomide.com> (raw)
In-Reply-To: <1353351832-6685-5-git-send-email-mgreer@animalcreek.com>
* Mark A. Greer <mgreer@animalcreek.com> [121119 11:06]:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
>
> The omap-aes driver should not check the CPU class or the
> type of OMAP device its on. The platform code should do
> that instead.
Similar patch for this one too should be queued already.
Regards,
Tony
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
> drivers/crypto/omap-aes.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index 093a8af..628c3cc 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -941,11 +941,6 @@ static int __init omap_aes_mod_init(void)
> {
> pr_info("loading %s driver\n", "omap-aes");
>
> - if (!cpu_class_is_omap2() || omap_type() != OMAP2_DEVICE_TYPE_SEC) {
> - pr_err("Unsupported cpu\n");
> - return -ENODEV;
> - }
> -
> return platform_driver_register(&omap_aes_driver);
> }
>
> --
> 1.7.12
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] crypto: omap-aes: Remove cpu_is/omap_type check from driver
Date: Tue, 20 Nov 2012 17:03:43 -0800 [thread overview]
Message-ID: <20121121010343.GS18567@atomide.com> (raw)
In-Reply-To: <1353351832-6685-5-git-send-email-mgreer@animalcreek.com>
* Mark A. Greer <mgreer@animalcreek.com> [121119 11:06]:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
>
> The omap-aes driver should not check the CPU class or the
> type of OMAP device its on. The platform code should do
> that instead.
Similar patch for this one too should be queued already.
Regards,
Tony
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
> drivers/crypto/omap-aes.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index 093a8af..628c3cc 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -941,11 +941,6 @@ static int __init omap_aes_mod_init(void)
> {
> pr_info("loading %s driver\n", "omap-aes");
>
> - if (!cpu_class_is_omap2() || omap_type() != OMAP2_DEVICE_TYPE_SEC) {
> - pr_err("Unsupported cpu\n");
> - return -ENODEV;
> - }
> -
> return platform_driver_register(&omap_aes_driver);
> }
>
> --
> 1.7.12
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-21 1:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 19:03 [PATCH 0/7] crypto: omap-aes updates Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 19:03 ` [PATCH 1/7] ARM: OMAP2xxx: hwmod: Convert AES crypto devcie data to hwmod Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 19:03 ` [PATCH 2/7] ARM: OMAP3xxx: hwmod: Convert AES crypto device " Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 19:03 ` [PATCH 3/7] ARM: OMAP2+: Remove unnecessary message when no AES IP is present Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 19:03 ` [PATCH 4/7] crypto: omap-aes: Remove cpu_is/omap_type check from driver Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-21 1:03 ` Tony Lindgren [this message]
2012-11-21 1:03 ` Tony Lindgren
2012-11-19 19:03 ` [PATCH 5/7] crypto: omap-aes: Convert to use pm_runtime API Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 19:03 ` [PATCH 6/7] crypto: omap-aes: Add code to use dmaengine API Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 19:03 ` [PATCH 7/7] crypto: omap-aes: Remove usage of private DMA API Mark A. Greer
2012-11-19 19:03 ` Mark A. Greer
2012-11-19 22:45 ` [PATCH 0/7] crypto: omap-aes updates Mark A. Greer
2012-11-19 22:45 ` Mark A. Greer
2012-11-20 12:08 ` Kasatkin, Dmitry
2012-11-20 12:08 ` Kasatkin, Dmitry
2012-12-05 10:28 ` Kasatkin, Dmitry
2012-12-05 10:28 ` Kasatkin, Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121010343.GS18567@atomide.com \
--to=tony@atomide.com \
--cc=davem@davemloft.net \
--cc=dmitry.kasatkin@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=paul@pwsan.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.