From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] gpio: Add simple poweroff-gpio driver
Date: Wed, 21 Nov 2012 13:20:23 +0000 [thread overview]
Message-ID: <20121121132023.3DB5F3E0A01@localhost> (raw)
In-Reply-To: <CACxGe6tgNVH9zeafMRKXcRUZmQjQXrAy_QtvhxpTT74200Hnxg@mail.gmail.com>
On Thu, 15 Nov 2012 18:21:20 +0000, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Nov 15, 2012 at 6:11 PM, Jamie Lentin <jm@lentin.co.uk> wrote:
> > On Thu, 15 Nov 2012, Grant Likely wrote:
> >
> >> On Sun, 11 Nov 2012 17:21:29 +0100, Andrew Lunn <andrew@lunn.ch> wrote:
> >>>
> >>> From: Jamie Lentin <jm@lentin.co.uk>
> >>>
> >>> Given appropriate devicetree bindings, this driver registers a
> >>> pm_power_off function to set a GPIO line high/low to power down
> >>> your board.
> >>>
> >>> Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
> >>> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> >>> ---
> >>> .../devicetree/bindings/gpio/gpio-poweroff.txt | 22 ++++
> >>> drivers/gpio/Kconfig | 10 ++
> >>> drivers/gpio/Makefile | 2 +
> >>> drivers/gpio/gpio-poweroff.c | 129
> >>> ++++++++++++++++++++
> >>
> >>
> >> This isn't a gpio controller driver. Don't put it into drivers/gpio
> >
> >
> > There's a v2 which puts it in drivers/power/reset/gpio-poweroff.c
>
> Okay, thanks.
>
> g.
So... I just read the power sequence proposal patch series which is
remarkably like a superset of what is needed here. Does it make sense to
use a power sequence for doing generic power off instead of this
interface?
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 1/3] gpio: Add simple poweroff-gpio driver
Date: Wed, 21 Nov 2012 13:20:23 +0000 [thread overview]
Message-ID: <20121121132023.3DB5F3E0A01@localhost> (raw)
In-Reply-To: <CACxGe6tgNVH9zeafMRKXcRUZmQjQXrAy_QtvhxpTT74200Hnxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 15 Nov 2012 18:21:20 +0000, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> On Thu, Nov 15, 2012 at 6:11 PM, Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org> wrote:
> > On Thu, 15 Nov 2012, Grant Likely wrote:
> >
> >> On Sun, 11 Nov 2012 17:21:29 +0100, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:
> >>>
> >>> From: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
> >>>
> >>> Given appropriate devicetree bindings, this driver registers a
> >>> pm_power_off function to set a GPIO line high/low to power down
> >>> your board.
> >>>
> >>> Signed-off-by: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
> >>> Signed-off-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
> >>> ---
> >>> .../devicetree/bindings/gpio/gpio-poweroff.txt | 22 ++++
> >>> drivers/gpio/Kconfig | 10 ++
> >>> drivers/gpio/Makefile | 2 +
> >>> drivers/gpio/gpio-poweroff.c | 129
> >>> ++++++++++++++++++++
> >>
> >>
> >> This isn't a gpio controller driver. Don't put it into drivers/gpio
> >
> >
> > There's a v2 which puts it in drivers/power/reset/gpio-poweroff.c
>
> Okay, thanks.
>
> g.
So... I just read the power sequence proposal patch series which is
remarkably like a superset of what is needed here. Does it make sense to
use a power sequence for doing generic power off instead of this
interface?
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2012-11-21 13:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 16:21 [PATCH 0/3] GPIO driver to turn power off Andrew Lunn
2012-11-11 16:21 ` Andrew Lunn
2012-11-11 16:21 ` [PATCH 1/3] gpio: Add simple poweroff-gpio driver Andrew Lunn
2012-11-11 16:21 ` Andrew Lunn
2012-11-11 22:03 ` Stephen Warren
2012-11-11 22:03 ` Stephen Warren
2012-11-12 8:25 ` Andrew Lunn
2012-11-12 8:25 ` Andrew Lunn
2012-11-12 16:17 ` Stephen Warren
2012-11-12 16:17 ` Stephen Warren
2012-11-12 18:19 ` Andrew Lunn
2012-11-12 18:19 ` Andrew Lunn
2012-11-12 18:43 ` Anton Vorontsov
2012-11-12 18:43 ` Anton Vorontsov
2012-11-12 18:58 ` Stephen Warren
2012-11-12 18:58 ` Stephen Warren
2012-11-12 19:17 ` Anton Vorontsov
2012-11-12 19:17 ` Anton Vorontsov
2012-11-15 10:35 ` Linus Walleij
2012-11-15 10:35 ` Linus Walleij
2012-11-15 10:59 ` Anton Vorontsov
2012-11-15 10:59 ` Anton Vorontsov
2012-11-15 11:10 ` Linus Walleij
2012-11-15 11:10 ` Linus Walleij
2012-11-21 13:17 ` Grant Likely
2012-11-21 13:17 ` Grant Likely
2012-11-15 18:00 ` Stephen Warren
2012-11-15 18:00 ` Stephen Warren
2012-11-12 1:00 ` Linus Walleij
2012-11-12 1:00 ` Linus Walleij
2012-11-12 1:12 ` Anton Vorontsov
2012-11-12 1:12 ` Anton Vorontsov
2012-11-12 6:07 ` Andrew Lunn
2012-11-12 6:07 ` Andrew Lunn
2012-11-12 6:53 ` Anton Vorontsov
2012-11-12 6:53 ` Anton Vorontsov
2012-11-15 18:05 ` Grant Likely
2012-11-15 18:05 ` Grant Likely
2012-11-15 18:11 ` Jamie Lentin
2012-11-15 18:11 ` Jamie Lentin
2012-11-15 18:21 ` Grant Likely
2012-11-15 18:21 ` Grant Likely
2012-11-21 13:20 ` Grant Likely [this message]
2012-11-21 13:20 ` Grant Likely
2012-11-11 16:21 ` [PATCH 2/3] ARM: Kirkwood: Convert DNSKW to use gpio-poweroff Andrew Lunn
2012-11-11 16:21 ` Andrew Lunn
2012-11-11 16:21 ` [PATCH 3/3] ARM: Kirkwood: Convert IB62x0 " Andrew Lunn
2012-11-11 16:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121132023.3DB5F3E0A01@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.