From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: add a regulator driver for the AS3711 PMIC
Date: Thu, 22 Nov 2012 01:27:59 +0000 [thread overview]
Message-ID: <20121122012757.GF4371@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1211211918330.842@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Wed, Nov 21, 2012 at 07:21:11PM +0100, Guennadi Liakhovetski wrote:
> + if (!pdata) {
> + dev_err(&pdev->dev, "No platform data, exiting...\n");
> + return -ENODEV;
> + }
There's no reason to require platform data, the driver can still support
readback of the current device state for diagnostic purposes with no
configuration.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: add a regulator driver for the AS3711 PMIC
Date: Thu, 22 Nov 2012 10:27:59 +0900 [thread overview]
Message-ID: <20121122012757.GF4371@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1211211918330.842@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Wed, Nov 21, 2012 at 07:21:11PM +0100, Guennadi Liakhovetski wrote:
> + if (!pdata) {
> + dev_err(&pdev->dev, "No platform data, exiting...\n");
> + return -ENODEV;
> + }
There's no reason to require platform data, the driver can still support
readback of the current device state for diagnostic purposes with no
configuration.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-22 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 18:21 [PATCH 1/2] mfd: add an AS3711 PMIC MFD driver Guennadi Liakhovetski
2012-11-21 18:21 ` Guennadi Liakhovetski
2012-11-21 18:21 ` [PATCH 2/2] regulator: add a regulator driver for the AS3711 PMIC Guennadi Liakhovetski
2012-11-21 18:21 ` Guennadi Liakhovetski
2012-11-22 1:27 ` Mark Brown [this message]
2012-11-22 1:27 ` Mark Brown
2012-11-22 1:18 ` [PATCH 1/2] mfd: add an AS3711 PMIC MFD driver Mark Brown
2012-11-22 1:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122012757.GF4371@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.