From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver
Date: Thu, 22 Nov 2012 11:28:36 +0000 [thread overview]
Message-ID: <20121122112836.GF4328@gmail.com> (raw)
In-Reply-To: <20121121184256.GD18950@core.coreip.homeip.net>
On Wed, 21 Nov 2012, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Wed, Nov 14, 2012 at 01:47:14PM +0000, Lee Jones wrote:
> > @@ -272,6 +276,60 @@ static irqreturn_t bu21013_gpio_irq(int irq, void *device_data)
> > }
> >
> > /**
> > + * bu21013_gpio_board_init() - configures the touch panel
> > + * @reset_pin: reset pin number
> > + *
> > + * This function is used to configure the voltage and
> > + * reset the touch panel controller.
> > + */
> > +static int bu21013_gpio_board_init(int reset_pin)
> > +{
> > + int retval = 0;
> > +
> > + bu21013_devices++;
> > + if (bu21013_devices == 1) {
>
> This does not make sense. If gpio is per-device now then we should
> simply set it up and not count devices.
No problem. I'll fixup.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver
Date: Thu, 22 Nov 2012 11:28:36 +0000 [thread overview]
Message-ID: <20121122112836.GF4328@gmail.com> (raw)
In-Reply-To: <20121121184256.GD18950@core.coreip.homeip.net>
On Wed, 21 Nov 2012, Dmitry Torokhov wrote:
> Hi Lee,
>
> On Wed, Nov 14, 2012 at 01:47:14PM +0000, Lee Jones wrote:
> > @@ -272,6 +276,60 @@ static irqreturn_t bu21013_gpio_irq(int irq, void *device_data)
> > }
> >
> > /**
> > + * bu21013_gpio_board_init() - configures the touch panel
> > + * @reset_pin: reset pin number
> > + *
> > + * This function is used to configure the voltage and
> > + * reset the touch panel controller.
> > + */
> > +static int bu21013_gpio_board_init(int reset_pin)
> > +{
> > + int retval = 0;
> > +
> > + bu21013_devices++;
> > + if (bu21013_devices == 1) {
>
> This does not make sense. If gpio is per-device now then we should
> simply set it up and not count devices.
No problem. I'll fixup.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-22 18:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 13:47 [PATCH 0/5] Input related patches Lee Jones
2012-11-14 13:47 ` [PATCH 1/5] Input: bu21013_ts - Request a regulator that actually exists Lee Jones
2012-11-23 15:50 ` Lee Jones
2012-11-23 15:50 ` Lee Jones
2012-11-26 12:16 ` Lee Jones
2012-11-26 12:16 ` Lee Jones
2012-11-26 16:47 ` Dmitry Torokhov
2012-11-27 9:05 ` Lee Jones
2012-11-27 9:05 ` Lee Jones
2012-11-14 13:47 ` [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver Lee Jones
2012-11-21 18:42 ` Dmitry Torokhov
2012-11-22 11:28 ` Lee Jones [this message]
2012-11-22 11:28 ` Lee Jones
2012-11-22 12:10 ` Lee Jones
2012-11-23 15:52 ` Lee Jones
2012-11-23 15:52 ` Lee Jones
2012-11-24 7:43 ` Dmitry Torokhov
2012-11-26 10:43 ` Lee Jones
2012-11-26 10:43 ` Lee Jones
2012-11-26 12:01 ` [PATCH 2/5 v2] " Lee Jones
2012-11-26 16:46 ` Dmitry Torokhov
2012-11-27 9:07 ` Lee Jones
2012-11-27 9:07 ` Lee Jones
2012-11-14 13:47 ` [PATCH 3/5] Input: bu21013_ts - Add support for Device Tree booting Lee Jones
2012-11-23 15:52 ` Lee Jones
2012-11-23 15:52 ` Lee Jones
2012-11-24 7:50 ` Dmitry Torokhov
2012-11-26 9:07 ` Lee Jones
2012-11-26 9:07 ` Lee Jones
2012-11-26 9:31 ` Dmitry Torokhov
2012-11-26 10:50 ` [PATCH 3/5 v2] " Lee Jones
2012-11-27 11:38 ` [PATCH 3/5 v3] " Lee Jones
2012-11-27 11:38 ` Lee Jones
2012-11-14 13:47 ` [PATCH 4/5] Input: Enable STMPE keypad driver for Device Tree Lee Jones
2012-11-23 15:53 ` Lee Jones
2012-11-23 15:53 ` Lee Jones
2013-01-08 8:38 ` Lee Jones
2013-01-08 8:38 ` Lee Jones
2013-01-08 9:26 ` Dmitry Torokhov
2013-01-08 9:30 ` Dmitry Torokhov
2013-01-08 9:53 ` Lee Jones
2013-01-08 9:53 ` Lee Jones
2012-11-14 13:47 ` [PATCH 5/5] Documentation: Describe bindings for STMPE Keypad driver Lee Jones
2012-11-23 15:54 ` Lee Jones
2012-11-23 15:54 ` Lee Jones
2012-11-24 8:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122112836.GF4328@gmail.com \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.